lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date:   Tue, 21 Nov 2023 02:32:19 +0000
From:   Yusong Gao <a869920004@...il.com>
To:     a869920004@...il.com
Cc:     davem@...emloft.net, dhowells@...hat.com,
        dimitri.ledkov@...onical.com, dwmw2@...radead.org,
        herbert@...dor.apana.org.au, jarkko@...nel.org,
        keyrings@...r.kernel.org, linux-crypto@...r.kernel.org,
        linux-kernel@...r.kernel.org, lists@...ience.com,
        zohar@...ux.ibm.com, juergh@...ton.me
Subject: [RESEND PATCH v2] sign-file: Fix incorrect return values check

On Tue, Nov 21, 2023 at 7:44 AM Jarkko Sakkinen <jarkko@...nel.org>
wrote:
>
> On Mon Nov 20, 2023 at 3:33 AM EET, Yusong Gao wrote:
> > There are some wrong return values check in sign-file when call
> > OpenSSL
> > API. For example the CMS_final() return 1 for success or 0 for
> > failure.
>
> Why not make it a closed sentence and list the functions that need to
> be
> changed?
>
> > The ERR() check cond is wrong because of the program only check the
> > return value is < 0 instead of <= 0.
> >
>
> Lacking Fixes tag(s). See:
> ttps://www.kernel.org/doc/html/latest/process/submitting-patches.html
>
> > Link:
> > https://www.openssl.org/docs/manmaster/man3/CMS_final.html
> > https://www.openssl.org/docs/manmaster/man3/i2d_CMS_bio_stream.html
> > https://www.openssl.org/docs/manmaster/man3/i2d_PKCS7_bio.html
> > https://www.openssl.org/docs/manmaster/man3/BIO_free.html
>
> Replace with
>
> Link: https://www.openssl.org/docs/manmaster/man3/
>
> BR, Jarkko

Thanks a lot for you comments, I will fix that.

BR, Yusong Gao

Powered by blists - more mailing lists