linux-kernel - Re: [PATCH v17 020/116] KVM: TDX: create/destroy VM structure

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20231121191557.GI1109547@ls.amr.corp.intel.com>
Date:   Tue, 21 Nov 2023 11:15:57 -0800
From:   Isaku Yamahata <isaku.yamahata@...ux.intel.com>
To:     Binbin Wu <binbin.wu@...ux.intel.com>
Cc:     isaku.yamahata@...el.com, kvm@...r.kernel.org,
        linux-kernel@...r.kernel.org, isaku.yamahata@...il.com,
        Paolo Bonzini <pbonzini@...hat.com>, erdemaktas@...gle.com,
        Sean Christopherson <seanjc@...gle.com>,
        Sagi Shahar <sagis@...gle.com>,
        David Matlack <dmatlack@...gle.com>,
        Kai Huang <kai.huang@...el.com>,
        Zhi Wang <zhi.wang.linux@...il.com>, chen.bo@...el.com,
        hang.yuan@...el.com, tina.zhang@...el.com,
        Sean Christopherson <sean.j.christopherson@...el.com>,
        isaku.yamahata@...ux.intel.com
Subject: Re: [PATCH v17 020/116] KVM: TDX: create/destroy VM structure

On Sun, Nov 19, 2023 at 02:30:19PM +0800,
Binbin Wu <binbin.wu@...ux.intel.com> wrote:

> > +static int tdx_reclaim_page(hpa_t pa)
> > +{
> > +	int r;
> > +
> > +	r = __tdx_reclaim_page(pa);
> > +	if (!r)
> > +		tdx_clear_page(pa);
> > +	return r;
> > +}
> > +
> > +static void tdx_reclaim_td_page(unsigned long td_page_pa)
> 
> This function is used to reclaim td control sturcture pages like TDCX,
> TDVPX,
> TDVPR. Should this function name be more specific?
> For me, it is a bit confusing.
> 
> Or maybe do "td page" have specific meaning referring to these control
> structures
> pages in TDX?

As they are control page, how about tdx_reclaim_control_page()?
-- 
Isaku Yamahata <isaku.yamahata@...ux.intel.com>