linux-kernel - Re: [PATCH bpf-next v3 0/4] selftests/bpf: Update multiple prog_tests to use ASSERT

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <170059442432.1779.10625462603877960408.git-patchwork-notify@kernel.org>
Date:   Tue, 21 Nov 2023 19:20:24 +0000
From:   patchwork-bot+netdevbpf@...nel.org
To:     Yuran Pereira <yuran.pereira@...mail.com>
Cc:     bpf@...r.kernel.org, andrii@...nel.org, ast@...nel.org,
        haoluo@...gle.com, john.fastabend@...il.com, jolsa@...nel.org,
        kpsingh@...nel.org, linux-kernel-mentees@...ts.linuxfoundation.org,
        linux-kernel@...r.kernel.org, linux-kselftest@...r.kernel.org,
        martin.lau@...ux.dev, mykolal@...com, sdf@...gle.com,
        shuah@...nel.org, song@...nel.org, yonghong.song@...ux.dev
Subject: Re: [PATCH bpf-next v3 0/4] selftests/bpf: Update multiple prog_tests to
 use ASSERT_ macros

Hello:

This series was applied to bpf/bpf-next.git (master)
by Andrii Nakryiko <andrii@...nel.org>:

On Tue, 21 Nov 2023 05:33:14 +0530 you wrote:
> Multiple files/programs in `tools/testing/selftests/bpf/prog_tests/` still
> heavily use the `CHECK` macro, even when better `ASSERT_` alternatives are
> available.
> 
> As it was already pointed out by Yonghong Song [1] in the bpf selftests the use
> of the ASSERT_* series of macros is preferred over the CHECK macro.
> 
> [...]

Here is the summary with links:
  - [bpf-next,v3,1/4] selftests/bpf: Replaces the usage of CHECK calls for ASSERTs in bpf_tcp_ca
    https://git.kernel.org/bpf/bpf-next/c/b0e2a0395312
  - [bpf-next,v3,2/4] selftests/bpf: Replaces the usage of CHECK calls for ASSERTs in bind_perm
    https://git.kernel.org/bpf/bpf-next/c/3ec1114a9745
  - [bpf-next,v3,3/4] selftests/bpf: Replaces the usage of CHECK calls for ASSERTs in bpf_obj_id
    https://git.kernel.org/bpf/bpf-next/c/f125d09b99fc
  - [bpf-next,v3,4/4] selftests/bpf: Replaces the usage of CHECK calls for ASSERTs in vmlinux
    https://git.kernel.org/bpf/bpf-next/c/3ece0e85f679

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html