linux-kernel - Re: [PATCH 2/2] zstd: Backport Huffman speed improvement from upstream

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <41F084AA-F027-4288-9F26-E33337E1516A@meta.com>
Date:   Tue, 21 Nov 2023 20:35:18 +0000
From:   Nick Terrell <terrelln@...a.com>
To:     Linus Torvalds <torvalds@...ux-foundation.org>
CC:     Nick Terrell <terrelln@...a.com>,
        Nick Terrell <nickrterrell@...il.com>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Yann Collet <cyan@...a.com>,
        Kernel Team <kernel-team@...a.com>,
        Giovanni Cabiddu <giovanni.cabiddu@...el.com>
Subject: Re: [PATCH 2/2] zstd: Backport Huffman speed improvement from
 upstream



> On Nov 21, 2023, at 3:12 PM, Linus Torvalds <torvalds@...ux-foundation.org> wrote:
> 
> !-------------------------------------------------------------------|
>  This Message Is From an External Sender
> 
> |-------------------------------------------------------------------!
> 
> On Tue, 21 Nov 2023 at 11:59, Nick Terrell <terrelln@...a.com> wrote:
>> 
>> W.r.t. do { } while (0), our older Visual Studios CI jobs failed on the
>> do { } while (0) macros, because it complained about constant false
>> branches.
> 
> Wow. That is some truly incompetent compiler people.
> 
> I mean, really. As in "Why would you ever use that kind of garbage"
> incompetence.
> 
> Honestly, any coding rule that includes "don't use the do-while-zero
> construct" is actively broken shit.
> 
> Please just fix your upstream rules. Because they are incredible garbage.

Yeah, that’s the plan. Visual Studios fixed that compiler bug in VS2015 [0],
so we should be safe to migrate to safer macros. I’m going through and
doing that now, and will backport that to the kernel on top of this series.

[0] https://stackoverflow.com/a/36658783

>               Linus