linux-kernel - Re: [PATCH] net: stmmac: fix out-of-bounds read via memcpy detected by KASAN

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <ebbdf786-54d4-491c-ab81-de03006ec727@lunn.ch>
Date:   Tue, 21 Nov 2023 21:36:13 +0100
From:   Andrew Lunn <andrew@...n.ch>
To:     Ray Zhang <sgzhang@...gle.com>
Cc:     Alexandre Torgue <alexandre.torgue@...s.st.com>,
        Jose Abreu <joabreu@...opsys.com>,
        "David S. Miller" <davem@...emloft.net>,
        Eric Dumazet <edumazet@...gle.com>,
        Jakub Kicinski <kuba@...nel.org>,
        Paolo Abeni <pabeni@...hat.com>,
        Maxime Coquelin <mcoquelin.stm32@...il.com>,
        netdev@...r.kernel.org, linux-stm32@...md-mailman.stormreply.com,
        linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] net: stmmac: fix out-of-bounds read via memcpy detected
 by KASAN

>     >      q0_tx_irq_n: 4
>     >      q0_rx_pkt_n: 64
>     >      q0_rx_irq_n: 58
> 
>     What useful information does this list of statistics bring in the
>     commit message?
> 
> Each output line of "ethtool -S" is from the modified code: It shows the
> command still yields normal output results as expected.

Does it? Can you actually say that looking at it?

> No, since strscpy does the job already. Also I could not find ethtool_puts:
> where is it defined? Or do you mean ethtool_put_stat, which is inappropriate to
> use here since it requires a skb parameter?

https://patchwork.kernel.org/project/netdevbpf/patch/20231102-ethtool_puts_impl-v4-3-14e1e9278496@google.com/

Maybe check with Justin when we will resend that patch.

	Andrew