linux-kernel - Re: [PATCH v3 2/2] dt-bindings: serial: Add option to enable RS485 mode via GPIO

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <abaea407-c5ea-49fe-8161-51774f0be274@kernel.org>
Date:   Tue, 21 Nov 2023 08:04:05 +0100
From:   Krzysztof Kozlowski <krzk@...nel.org>
To:     Tomas Paukrt <tomaspaukrt@...il.cz>,
        Rob Herring <robh+dt@...nel.org>,
        Conor Dooley <conor+dt@...nel.org>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Jiri Slaby <jirislaby@...nel.org>
Cc:     linux-serial@...r.kernel.org,
        Lino Sanfilippo <LinoSanfilippo@....de>,
        linux-kernel@...r.kernel.org, devicetree@...r.kernel.org
Subject: Re: [PATCH v3 2/2] dt-bindings: serial: Add option to enable RS485
 mode via GPIO

On 20/11/2023 22:45, Tomas Paukrt wrote:
> Add the device tree property "rs485-mode-gpio".
> 
> Signed-off-by: Tomas Paukrt <tomaspaukrt@...il.cz>
> ---
>  Documentation/devicetree/bindings/serial/rs485.yaml | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/serial/rs485.yaml b/Documentation/devicetree/bindings/serial/rs485.yaml
> index 9418fd6..7a72f37 100644
> --- a/Documentation/devicetree/bindings/serial/rs485.yaml
> +++ b/Documentation/devicetree/bindings/serial/rs485.yaml
> @@ -47,6 +47,10 @@ properties:
>        later with proper ioctl.
>      $ref: /schemas/types.yaml#/definitions/flag
>  
> +  rs485-mode-gpio:
> +    description: GPIO pin to enable RS485 mode at boot time.
> +    maxItems: 1
> +

This does not look like generic RS485 property. Commit msg also does not
help to understand the context.

Best regards,
Krzysztof