linux-kernel - Re: [PATCH v7] HID: mcp2200: added driver for GPIOs of MCP2200

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <nycvar.YFH.7.76.2311210927510.29220@cbobk.fhfr.pm>
Date:   Tue, 21 Nov 2023 09:28:16 +0100 (CET)
From:   Jiri Kosina <jikos@...nel.org>
To:     Johannes Roith <johannes@...-linux.rocks>
cc:     sergeantsagara@...tonmail.com, andi.shyti@...nel.org,
        benjamin.tissoires@...hat.com, christophe.jaillet@...adoo.fr,
        linux-input@...r.kernel.org, linux-kernel@...r.kernel.org,
        rdunlap@...radead.org
Subject: Re: [PATCH v7] HID: mcp2200: added driver for GPIOs of MCP2200

On Thu, 21 Sep 2023, Johannes Roith wrote:

> Added a gpiochip compatible driver to control the 8 GPIOs of
> the MCP2200 by using the HID interface.
> 
> Using GPIOs with alternative functions (GP0<->SSPND, GP1<->USBCFG,
> GP6<->RXLED, GP7<->TXLED) will reset the functions, if set (unset by
> default).
> 
> The driver was tested while also using the UART of the chip. Setting
> and reading the GPIOs has no effect on the UART communication. However,
> a reset is triggered after the CONFIGURE command. If the GPIO Direction
> is constantly changed, this will affect the communication at low baud
> rates. This is a hardware problem of the MCP2200 and is not caused by
> the driver.
> 
> Signed-off-by: Johannes Roith <johannes@...-linux.rocks>

Now applied to hid.git#for-6.8/mcp2200. Thanks and sorry for the delay 
in the review.

-- 
Jiri Kosina
SUSE Labs