[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <ac3f3304-6dcd-470a-907c-32a63d3c39cf@linaro.org>
Date: Tue, 21 Nov 2023 09:31:13 +0100
From: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To: Dmitry Baryshkov <dmitry.baryshkov@...aro.org>,
Rob Herring <robh+dt@...nel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
Conor Dooley <conor+dt@...nel.org>,
Andy Gross <agross@...nel.org>,
Bjorn Andersson <andersson@...nel.org>,
Konrad Dybcio <konrad.dybcio@...aro.org>,
Hans de Goede <hdegoede@...hat.com>,
Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>,
Mark Gross <markgross@...nel.org>,
Heikki Krogerus <heikki.krogerus@...ux.intel.com>,
Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc: devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
linux-arm-msm@...r.kernel.org, platform-driver-x86@...r.kernel.org,
linux-usb@...r.kernel.org
Subject: Re: [PATCH v3 1/3] dt-bindings: connector: usb: add altmodes
description
On 20/11/2023 23:00, Dmitry Baryshkov wrote:
> Add description of the USB-C AltModes supported on the particular USB-C
> connector. This is required for devices like Qualcomm Robotics RB5,
> which have no other way to express alternative modes supported by the
> hardware platform.
>
> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@...aro.org>
> ---
> .../bindings/connector/usb-connector.yaml | 29 +++++++++++++++++++
> 1 file changed, 29 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/connector/usb-connector.yaml b/Documentation/devicetree/bindings/connector/usb-connector.yaml
> index 7c8a3e8430d3..c1aaac861d9d 100644
> --- a/Documentation/devicetree/bindings/connector/usb-connector.yaml
> +++ b/Documentation/devicetree/bindings/connector/usb-connector.yaml
> @@ -171,6 +171,28 @@ properties:
> offer the power, Capability Mismatch is set. Required for power sink and
> power dual role.
>
> + altmodes:
> + type: object
> + description: List of Alternative Modes supported by the schematics on the
> + particular device. This is only necessary if there are no other means to
> + discover supported alternative modes (e.g. through the UCSI firmware
> + interface).
> +
> + patternProperties:
> + "^(displayport)$":
This is just a property, so should be under "properties:".
The rest looks good to me, but I don't know USB that much to judge.
Best regards,
Krzysztof
Powered by blists - more mailing lists