lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 21 Nov 2023 16:46:01 +0800 From: kernel test robot <lkp@...el.com> To: Philipp Stanner <pstanner@...hat.com>, Bjorn Helgaas <helgaas@...nel.org>, Arnd Bergmann <arnd@...nel.org>, Andrew Morton <akpm@...ux-foundation.org>, Randy Dunlap <rdunlap@...radead.org>, Jason Gunthorpe <jgg@...pe.ca>, Eric Auger <eric.auger@...hat.com>, Kent Overstreet <kmo@...erainc.com>, Niklas Schnelle <schnelle@...ux.ibm.com>, NeilBrown <neilb@...e.de>, John Sanpe <sanpeqf@...il.com>, Dave Jiang <dave.jiang@...el.com>, Yury Norov <yury.norov@...il.com>, Kees Cook <keescook@...omium.org>, "Masami Hiramatsu (Google)" <mhiramat@...nel.org>, David Gow <davidgow@...gle.com>, Herbert Xu <herbert@...dor.apana.org.au>, Thomas Gleixner <tglx@...utronix.de>, "wuqiang.matt" <wuqiang.matt@...edance.com>, Jason Baron <jbaron@...mai.com>, Ben Dooks <ben.dooks@...ethink.co.uk>, Danilo Krummrich <dakr@...hat.com> Cc: oe-kbuild-all@...ts.linux.dev, Linux Memory Management List <linux-mm@...ck.org>, linux-kernel@...r.kernel.org, linux-pci@...r.kernel.org Subject: Re: [PATCH 1/4] lib: move pci_iomap.c to drivers/pci/ Hi Philipp, kernel test robot noticed the following build warnings: [auto build test WARNING on pci/next] [also build test WARNING on pci/for-linus linus/master v6.7-rc2 next-20231121] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://github.com/intel-lab-lkp/linux/commits/Philipp-Stanner/lib-move-pci_iomap-c-to-drivers-pci/20231121-060258 base: https://git.kernel.org/pub/scm/linux/kernel/git/pci/pci.git next patch link: https://lore.kernel.org/r/20231120215945.52027-3-pstanner%40redhat.com patch subject: [PATCH 1/4] lib: move pci_iomap.c to drivers/pci/ config: x86_64-buildonly-randconfig-004-20231121 (https://download.01.org/0day-ci/archive/20231121/202311211641.ThSnuFs7-lkp@intel.com/config) compiler: gcc-7 (Ubuntu 7.5.0-6ubuntu2) 7.5.0 reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20231121/202311211641.ThSnuFs7-lkp@intel.com/reproduce) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot <lkp@...el.com> | Closes: https://lore.kernel.org/oe-kbuild-all/202311211641.ThSnuFs7-lkp@intel.com/ All warnings (new ones prefixed by >>): drivers/pci/iomap.c:27:15: error: redefinition of 'pci_iomap_range' void __iomem *pci_iomap_range(struct pci_dev *dev, ^~~~~~~~~~~~~~~ In file included from include/asm-generic/iomap.h:113:0, from include/asm-generic/io.h:16, from arch/x86/include/asm/io.h:327, from include/linux/io.h:13, from include/linux/pci.h:39, from drivers/pci/iomap.c:7: include/asm-generic/pci_iomap.h:44:29: note: previous definition of 'pci_iomap_range' was here static inline void __iomem *pci_iomap_range(struct pci_dev *dev, int bar, ^~~~~~~~~~~~~~~ drivers/pci/iomap.c: In function 'pci_iomap_range': drivers/pci/iomap.c:43:10: error: implicit declaration of function '__pci_ioport_map'; did you mean 'devm_ioport_map'? [-Werror=implicit-function-declaration] return __pci_ioport_map(dev, start, len); ^~~~~~~~~~~~~~~~ devm_ioport_map >> drivers/pci/iomap.c:43:10: warning: return makes pointer from integer without a cast [-Wint-conversion] return __pci_ioport_map(dev, start, len); ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ drivers/pci/iomap.c: At top level: drivers/pci/iomap.c:67:15: error: redefinition of 'pci_iomap_wc_range' void __iomem *pci_iomap_wc_range(struct pci_dev *dev, ^~~~~~~~~~~~~~~~~~ In file included from include/asm-generic/iomap.h:113:0, from include/asm-generic/io.h:16, from arch/x86/include/asm/io.h:327, from include/linux/io.h:13, from include/linux/pci.h:39, from drivers/pci/iomap.c:7: include/asm-generic/pci_iomap.h:50:29: note: previous definition of 'pci_iomap_wc_range' was here static inline void __iomem *pci_iomap_wc_range(struct pci_dev *dev, int bar, ^~~~~~~~~~~~~~~~~~ drivers/pci/iomap.c:110:15: error: redefinition of 'pci_iomap' void __iomem *pci_iomap(struct pci_dev *dev, int bar, unsigned long maxlen) ^~~~~~~~~ In file included from include/asm-generic/iomap.h:113:0, from include/asm-generic/io.h:16, from arch/x86/include/asm/io.h:327, from include/linux/io.h:13, from include/linux/pci.h:39, from drivers/pci/iomap.c:7: include/asm-generic/pci_iomap.h:35:29: note: previous definition of 'pci_iomap' was here static inline void __iomem *pci_iomap(struct pci_dev *dev, int bar, unsigned long max) ^~~~~~~~~ drivers/pci/iomap.c:131:15: error: redefinition of 'pci_iomap_wc' void __iomem *pci_iomap_wc(struct pci_dev *dev, int bar, unsigned long maxlen) ^~~~~~~~~~~~ In file included from include/asm-generic/iomap.h:113:0, from include/asm-generic/io.h:16, from arch/x86/include/asm/io.h:327, from include/linux/io.h:13, from include/linux/pci.h:39, from drivers/pci/iomap.c:7: include/asm-generic/pci_iomap.h:40:29: note: previous definition of 'pci_iomap_wc' was here static inline void __iomem *pci_iomap_wc(struct pci_dev *dev, int bar, unsigned long max) ^~~~~~~~~~~~ cc1: some warnings being treated as errors Kconfig warnings: (for reference only) WARNING: unmet direct dependencies detected for GENERIC_PCI_IOMAP Depends on [n]: PCI [=n] Selected by [y]: - GENERIC_IOMAP [=y] vim +43 drivers/pci/iomap.c 66eab4df288aae lib/pci_iomap.c Michael S. Tsirkin 2011-11-24 11 66eab4df288aae lib/pci_iomap.c Michael S. Tsirkin 2011-11-24 12 /** eb29d8d2aad706 lib/pci_iomap.c Michael S. Tsirkin 2013-05-29 13 * pci_iomap_range - create a virtual mapping cookie for a PCI BAR 66eab4df288aae lib/pci_iomap.c Michael S. Tsirkin 2011-11-24 14 * @dev: PCI device that owns the BAR 66eab4df288aae lib/pci_iomap.c Michael S. Tsirkin 2011-11-24 15 * @bar: BAR number eb29d8d2aad706 lib/pci_iomap.c Michael S. Tsirkin 2013-05-29 16 * @offset: map memory at the given offset in BAR eb29d8d2aad706 lib/pci_iomap.c Michael S. Tsirkin 2013-05-29 17 * @maxlen: max length of the memory to map 66eab4df288aae lib/pci_iomap.c Michael S. Tsirkin 2011-11-24 18 * 66eab4df288aae lib/pci_iomap.c Michael S. Tsirkin 2011-11-24 19 * Using this function you will get a __iomem address to your device BAR. 66eab4df288aae lib/pci_iomap.c Michael S. Tsirkin 2011-11-24 20 * You can access it using ioread*() and iowrite*(). These functions hide 66eab4df288aae lib/pci_iomap.c Michael S. Tsirkin 2011-11-24 21 * the details if this is a MMIO or PIO address space and will just do what 66eab4df288aae lib/pci_iomap.c Michael S. Tsirkin 2011-11-24 22 * you expect from them in the correct way. 66eab4df288aae lib/pci_iomap.c Michael S. Tsirkin 2011-11-24 23 * 66eab4df288aae lib/pci_iomap.c Michael S. Tsirkin 2011-11-24 24 * @maxlen specifies the maximum length to map. If you want to get access to eb29d8d2aad706 lib/pci_iomap.c Michael S. Tsirkin 2013-05-29 25 * the complete BAR from offset to the end, pass %0 here. 66eab4df288aae lib/pci_iomap.c Michael S. Tsirkin 2011-11-24 26 * */ eb29d8d2aad706 lib/pci_iomap.c Michael S. Tsirkin 2013-05-29 27 void __iomem *pci_iomap_range(struct pci_dev *dev, eb29d8d2aad706 lib/pci_iomap.c Michael S. Tsirkin 2013-05-29 28 int bar, eb29d8d2aad706 lib/pci_iomap.c Michael S. Tsirkin 2013-05-29 29 unsigned long offset, eb29d8d2aad706 lib/pci_iomap.c Michael S. Tsirkin 2013-05-29 30 unsigned long maxlen) 66eab4df288aae lib/pci_iomap.c Michael S. Tsirkin 2011-11-24 31 { 66eab4df288aae lib/pci_iomap.c Michael S. Tsirkin 2011-11-24 32 resource_size_t start = pci_resource_start(dev, bar); 66eab4df288aae lib/pci_iomap.c Michael S. Tsirkin 2011-11-24 33 resource_size_t len = pci_resource_len(dev, bar); 66eab4df288aae lib/pci_iomap.c Michael S. Tsirkin 2011-11-24 34 unsigned long flags = pci_resource_flags(dev, bar); 66eab4df288aae lib/pci_iomap.c Michael S. Tsirkin 2011-11-24 35 eb29d8d2aad706 lib/pci_iomap.c Michael S. Tsirkin 2013-05-29 36 if (len <= offset || !start) 66eab4df288aae lib/pci_iomap.c Michael S. Tsirkin 2011-11-24 37 return NULL; eb29d8d2aad706 lib/pci_iomap.c Michael S. Tsirkin 2013-05-29 38 len -= offset; eb29d8d2aad706 lib/pci_iomap.c Michael S. Tsirkin 2013-05-29 39 start += offset; 66eab4df288aae lib/pci_iomap.c Michael S. Tsirkin 2011-11-24 40 if (maxlen && len > maxlen) 66eab4df288aae lib/pci_iomap.c Michael S. Tsirkin 2011-11-24 41 len = maxlen; 66eab4df288aae lib/pci_iomap.c Michael S. Tsirkin 2011-11-24 42 if (flags & IORESOURCE_IO) b923650b84068b lib/pci_iomap.c Michael S. Tsirkin 2012-01-30 @43 return __pci_ioport_map(dev, start, len); 92b19ff50e8f24 lib/pci_iomap.c Dan Williams 2015-08-10 44 if (flags & IORESOURCE_MEM) 66eab4df288aae lib/pci_iomap.c Michael S. Tsirkin 2011-11-24 45 return ioremap(start, len); 66eab4df288aae lib/pci_iomap.c Michael S. Tsirkin 2011-11-24 46 /* What? */ 66eab4df288aae lib/pci_iomap.c Michael S. Tsirkin 2011-11-24 47 return NULL; 66eab4df288aae lib/pci_iomap.c Michael S. Tsirkin 2011-11-24 48 } eb29d8d2aad706 lib/pci_iomap.c Michael S. Tsirkin 2013-05-29 49 EXPORT_SYMBOL(pci_iomap_range); 66eab4df288aae lib/pci_iomap.c Michael S. Tsirkin 2011-11-24 50 -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki
Powered by blists - more mailing lists