linux-kernel - Re: [PATCH] gpu: display: remove unnecessary braces to fix coding style

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <bac617fe-6b23-411f-8dc9-c97cc84208f3@amd.com>
Date:   Tue, 21 Nov 2023 10:17:00 +0100
From:   Christian König <christian.koenig@....com>
To:     RutingZhang <u202112078@...t.edu.cn>,
        Harry Wentland <harry.wentland@....com>,
        Leo Li <sunpeng.li@....com>,
        Rodrigo Siqueira <Rodrigo.Siqueira@....com>,
        Alex Deucher <alexander.deucher@....com>,
        "Pan, Xinhui" <Xinhui.Pan@....com>,
        David Airlie <airlied@...il.com>,
        Daniel Vetter <daniel@...ll.ch>
Cc:     hust-os-kernel-patches@...glegroups.com,
        Dongliang Mu <dzm91@...t.edu.cn>,
        amd-gfx@...ts.freedesktop.org, dri-devel@...ts.freedesktop.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] gpu: display: remove unnecessary braces to fix coding
 style

Am 21.11.23 um 05:36 schrieb RutingZhang:
> checkpatch complains that:
>
> WARNING: braces {} are not necessary for single statement blocks
> +                if (pool->base.irqs != NULL) {
> +                        dal_irq_service_destroy(&pool->base.irqs);
> +                }
>
> Fixed it by removing unnecessary braces to fix the coding style issue.
>
> Signed-off-by: RutingZhang <u202112078@...t.edu.cn>
> Reviewed-by: Dongliang Mu <dzm91@...t.edu.cn>

Subject line prefix should be "drm/amdgpu".

Apart from this nit it looks good to me, but might be already fixed 
internally.

Regards,
Christian.

> ---
>   drivers/gpu/drm/amd/display/dc/dcn21/dcn21_resource.c | 3 +--
>   1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/display/dc/dcn21/dcn21_resource.c b/drivers/gpu/drm/amd/display/dc/dcn21/dcn21_resource.c
> index 447de8492594..6835dbb733a2 100644
> --- a/drivers/gpu/drm/amd/display/dc/dcn21/dcn21_resource.c
> +++ b/drivers/gpu/drm/amd/display/dc/dcn21/dcn21_resource.c
> @@ -713,9 +713,8 @@ static void dcn21_resource_destruct(struct dcn21_resource_pool *pool)
>   			pool->base.hubps[i] = NULL;
>   		}
>   
> -		if (pool->base.irqs != NULL) {
> +		if (pool->base.irqs != NULL)
>   			dal_irq_service_destroy(&pool->base.irqs);
> -		}
>   	}
>   
>   	for (i = 0; i < pool->base.res_cap->num_ddc; i++) {