linux-kernel - Re: spi: imx: Increase imx51 ecspi burst length fails on imx6dl and imx8mm

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 21 Nov 2023 11:34:26 +0100
From:   linux@...ler.io
To:     Francesco Dolcini <francesco@...cini.it>
Cc:     Thorsten Leemhuis <regressions@...mhuis.info>,
        Stefan Moring <stefan.moring@...hnolution.nl>,
        Linux regressions mailing list <regressions@...ts.linux.dev>,
        Mark Brown <broonie@...nel.org>, linux-kernel@...r.kernel.org,
        linux-spi@...r.kernel.org
Subject: Re: spi: imx: Increase imx51 ecspi burst length fails on imx6dl and
 imx8mm

Hi

At least in my test-case the  commit is NOT introducing this regression, because the bits_per_word is 8, so the result is the same
spi: imx: Take in account bits per word instead of assuming 8-bits
5f66db08cbd3ca471c66bacb0282902c79db9274

I do not have the latest  mx-sdma firmware can you tell me where I get it. On 
https://git.kernel.org/pub/scm/linux/kernel/git/firmware/linux-firmware.git/tree/imx/sdma
the latest I found was 4.5

I tried to debug the code but it's hard vor me to understand where the problem could be.
I saw then I disable the dma with set

imx51_ecspi_devtype_data {
.has_dmamode = false,
}
the SPI is working fine.

Should I do some more tests, do some loggings.. 
Please let me know

Regards 
Stefan Bigler

Am 2023-11-21T10:16:57.000+01:00 hat Francesco Dolcini <francesco@...cini.it> geschrieben:
>  On Tue, Nov 21, 2023 at 10:06:51AM +0100, Thorsten Leemhuis wrote:
> 
> >    On 20.11.23 18:48, Francesco Dolcini wrote:
> > 
> > >     On Mon, Nov 20, 2023 at 04:30:15PM +0100, Stefan Moring wrote:
> > > 
> > > >     Can you verify the values used for the transfer,  spi_imx->count and spi_imx->
> > > >   bits_per_word inside the mx51_ecpsi_prepare_transfer() method? Those are the
> > > >   only two things that changed in the commits. Maybe compare them to the working
> > > >   version?
> > >    
> > >   I would suggest to bisect the issue to the actual commit that
> > >   introduced the regression, I do not think this was done yet.
> >   
> >  I think it was. To quote
>  Whoops, you are right.
> 
> 
> >    spi: Increase imx51 ecspi burst length based on transfer length
> >  15a6af94a2779d5dfb42ee4bfac858ea8e964a3f
> >  
> >  spi: imx: Take in account bits per word instead of assuming 8-bits
> >  5f66db08cbd3ca471c66bacb0282902c79db9274
>  
> Do we know which one of those two commits introduces this regression?
> 
Francesco