lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <8fd1affd-936d-415e-9f1f-b0415b68ddb6@collabora.com>
Date:   Tue, 21 Nov 2023 11:59:14 +0100
From:   AngeloGioacchino Del Regno 
        <angelogioacchino.delregno@...labora.com>
To:     Nícolas F. R. A. Prado 
        <nfraprado@...labora.com>, Chun-Kuang Hu <chunkuang.hu@...nel.org>
Cc:     kernel@...labora.com, Bo-Chen Chen <rex-bc.chen@...iatek.com>,
        CK Hu <ck.hu@...iatek.com>, Daniel Vetter <daniel@...ll.ch>,
        David Airlie <airlied@...il.com>,
        Dmitry Osipenko <dmitry.osipenko@...labora.com>,
        Guillaume Ranquet <granquet@...libre.com>,
        Markus Schneider-Pargmann <msp@...libre.com>,
        Matthias Brugger <matthias.bgg@...il.com>,
        Philipp Zabel <p.zabel@...gutronix.de>,
        dri-devel@...ts.freedesktop.org,
        linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
        linux-mediatek@...ts.infradead.org
Subject: Re: [PATCH] drm/mediatek: dp: Add phy_mtk_dp module as pre-dependency

Il 20/11/23 21:28, Nícolas F. R. A. Prado ha scritto:
> The mtk_dp driver registers a phy device which is handled by the
> phy_mtk_dp driver and assumes that the phy probe will complete
> synchronously, proceeding to make use of functionality exposed by that
> driver right away. This assumption however is false when the phy driver
> is built as a module, causing the mtk_dp driver to fail probe in this
> case.
> 
> Add the phy_mtk_dp module as a pre-dependency to the mtk_dp module to
> ensure the phy module has been loaded before the dp, so that the phy
> probe happens synchrounously and the mtk_dp driver can probe
> successfully even with the phy driver built as a module.
> 

You forgot a Suggested-by here :-P

> Fixes: f70ac097a2cf ("drm/mediatek: Add MT8195 Embedded DisplayPort driver")
> Signed-off-by: Nícolas F. R. A. Prado <nfraprado@...labora.com>

It's fine anyway; being the best solution that we can use:

Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com>

> 
> ---
> 
>   drivers/gpu/drm/mediatek/mtk_dp.c | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/gpu/drm/mediatek/mtk_dp.c b/drivers/gpu/drm/mediatek/mtk_dp.c
> index e4c16ba9902d..2136a596efa1 100644
> --- a/drivers/gpu/drm/mediatek/mtk_dp.c
> +++ b/drivers/gpu/drm/mediatek/mtk_dp.c
> @@ -2818,3 +2818,4 @@ MODULE_AUTHOR("Markus Schneider-Pargmann <msp@...libre.com>");
>   MODULE_AUTHOR("Bo-Chen Chen <rex-bc.chen@...iatek.com>");
>   MODULE_DESCRIPTION("MediaTek DisplayPort Driver");
>   MODULE_LICENSE("GPL");
> +MODULE_SOFTDEP("pre: phy_mtk_dp");

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ