linux-kernel - Re: [PATCH v2] dpll: Fix potential msg memleak when genlmsg_put

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <34cb7d4b-58f8-446e-9259-0a234380213c@linux.dev>
Date:   Tue, 21 Nov 2023 11:20:38 +0000
From:   Vadim Fedorenko <vadim.fedorenko@...ux.dev>
To:     Hao Ge <gehao@...inos.cn>, arkadiusz.kubalewski@...el.com
Cc:     jiri@...nulli.us, michal.michalik@...el.com, davem@...emloft.net,
        linux-kernel@...r.kernel.org, netdev@...r.kernel.org
Subject: Re: [PATCH v2] dpll: Fix potential msg memleak when genlmsg_put_reply
 failed

On 21/11/2023 20:37, Hao Ge wrote:
> We should clean the skb resource if genlmsg_put_reply failed.
> 
> Fixes: 9d71b54b65b1 ("dpll: netlink: Add DPLL framework base functions")
> Signed-off-by: Hao Ge <gehao@...inos.cn>
> ---
> v1 -> v2: change title due to add some similar fix for some similar cases
> ---
>   drivers/dpll/dpll_netlink.c | 17 ++++++++++++-----
>   1 file changed, 12 insertions(+), 5 deletions(-)

Thanks!

Reviewed-by: Vadim Fedorenko <vadim.fedorenko@...ux.dev>