linux-kernel - Re: [PATCH RFC 20/37] mm: compaction: Reserve metadata storage in compaction

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 21 Nov 2023 11:54:36 +0000
From:   Alexandru Elisei <alexandru.elisei@....com>
To:     Peter Collingbourne <pcc@...gle.com>
Cc:     catalin.marinas@....com, will@...nel.org, oliver.upton@...ux.dev,
        maz@...nel.org, james.morse@....com, suzuki.poulose@....com,
        yuzenghui@...wei.com, arnd@...db.de, akpm@...ux-foundation.org,
        mingo@...hat.com, peterz@...radead.org, juri.lelli@...hat.com,
        vincent.guittot@...aro.org, dietmar.eggemann@....com,
        rostedt@...dmis.org, bsegall@...gle.com, mgorman@...e.de,
        bristot@...hat.com, vschneid@...hat.com, mhiramat@...nel.org,
        rppt@...nel.org, hughd@...gle.com, steven.price@....com,
        anshuman.khandual@....com, vincenzo.frascino@....com,
        david@...hat.com, eugenis@...gle.com, kcc@...gle.com,
        hyesoo.yu@...sung.com, linux-arm-kernel@...ts.infradead.org,
        linux-kernel@...r.kernel.org, kvmarm@...ts.linux.dev,
        linux-fsdevel@...r.kernel.org, linux-arch@...r.kernel.org,
        linux-mm@...ck.org, linux-trace-kernel@...r.kernel.org
Subject: Re: [PATCH RFC 20/37] mm: compaction: Reserve metadata storage in
 compaction_alloc()

Hi Peter,

On Mon, Nov 20, 2023 at 08:49:32PM -0800, Peter Collingbourne wrote:
> Hi Alexandru,
> 
> On Wed, Aug 23, 2023 at 6:16 AM Alexandru Elisei
> <alexandru.elisei@....com> wrote:
> >
> > If the source page being migrated has metadata associated with it, make
> > sure to reserve the metadata storage when choosing a suitable destination
> > page from the free list.
> >
> > Signed-off-by: Alexandru Elisei <alexandru.elisei@....com>
> > ---
> >  mm/compaction.c | 9 +++++++++
> >  mm/internal.h   | 1 +
> >  2 files changed, 10 insertions(+)
> >
> > diff --git a/mm/compaction.c b/mm/compaction.c
> > index cc0139fa0cb0..af2ee3085623 100644
> > --- a/mm/compaction.c
> > +++ b/mm/compaction.c
> > @@ -570,6 +570,7 @@ static unsigned long isolate_freepages_block(struct compact_control *cc,
> >         bool locked = false;
> >         unsigned long blockpfn = *start_pfn;
> >         unsigned int order;
> > +       int ret;
> >
> >         /* Strict mode is for isolation, speed is secondary */
> >         if (strict)
> > @@ -626,6 +627,11 @@ static unsigned long isolate_freepages_block(struct compact_control *cc,
> >
> >                 /* Found a free page, will break it into order-0 pages */
> >                 order = buddy_order(page);
> > +               if (metadata_storage_enabled() && cc->reserve_metadata) {
> > +                       ret = reserve_metadata_storage(page, order, cc->gfp_mask);
> 
> At this point the zone lock is held and preemption is disabled, which
> makes it invalid to call reserve_metadata_storage.

You are correct, I missed that. I dropped reserving tag storage during
compaction in the next iteration, so fortunately I unintentionally fixed
it.

Thanks,
Alex

> 
> Peter
> 
> > +                       if (ret)
> > +                               goto isolate_fail;
> > +               }
> >                 isolated = __isolate_free_page(page, order);
> >                 if (!isolated)
> >                         break;
> > @@ -1757,6 +1763,9 @@ static struct folio *compaction_alloc(struct folio *src, unsigned long data)
> >         struct compact_control *cc = (struct compact_control *)data;
> >         struct folio *dst;
> >
> > +       if (metadata_storage_enabled())
> > +               cc->reserve_metadata = folio_has_metadata(src);
> > +
> >         if (list_empty(&cc->freepages)) {
> >                 isolate_freepages(cc);
> >
> > diff --git a/mm/internal.h b/mm/internal.h
> > index d28ac0085f61..046cc264bfbe 100644
> > --- a/mm/internal.h
> > +++ b/mm/internal.h
> > @@ -492,6 +492,7 @@ struct compact_control {
> >                                          */
> >         bool alloc_contig;              /* alloc_contig_range allocation */
> >         bool source_has_metadata;       /* source pages have associated metadata */
> > +       bool reserve_metadata;
> >  };
> >
> >  /*
> > --
> > 2.41.0
> >