[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <64d598b7-cff3-4036-8b6b-dea3083dd716@arm.com>
Date: Tue, 21 Nov 2023 13:07:08 +0000
From: Lukasz Luba <lukasz.luba@....com>
To: m.majewski2@...sung.com
Cc: Bartlomiej Zolnierkiewicz <bzolnier@...il.com>,
"linux-pm@...r.kernel.org" <linux-pm@...r.kernel.org>,
"linux-arm-kernel@...ts.infradead.org"
<linux-arm-kernel@...ts.infradead.org>,
"linux-samsung-soc@...r.kernel.org"
<linux-samsung-soc@...r.kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>,
"Rafael J. Wysocki" <rafael@...nel.org>,
Daniel Lezcano <daniel.lezcano@...aro.org>,
"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
Amit Kucheria <amitk@...nel.org>,
Zhang Rui <rui.zhang@...el.com>,
ALIM AKHTAR <alim.akhtar@...sung.com>,
Liam Girdwood <lgirdwood@...il.com>,
Mark Brown <broonie@...nel.org>,
Marek Szyprowski <m.szyprowski@...sung.com>
Subject: Re: [PATCH v5 8/9] thermal: exynos: use BIT wherever possible
On 11/21/23 12:54, Mateusz Majewski wrote:
> Hi,
>
>>> @@ -590,15 +590,15 @@ static void exynos5433_tmu_control(struct platform_device *pdev, bool on)
>>> continue;
>>>
>>> interrupt_en |=
>>> - (1 << (EXYNOS7_TMU_INTEN_RISE0_SHIFT + i));
>>> + BIT(EXYNOS7_TMU_INTEN_RISE0_SHIFT + i);
>>> }
>>>
>>> interrupt_en |=
>>> interrupt_en << EXYNOS_TMU_INTEN_FALL0_SHIFT;
>>>
>>> - con |= (1 << EXYNOS_TMU_CORE_EN_SHIFT);
>>> + con |= BIT(EXYNOS_TMU_CORE_EN_SHIFT);
>>> } else
>>
>> Minor issue: the if-else segment here. When the 'if' has the
>> brackets, then the 'else' should have them as well,
>> even if there is only a single line under 'else'.
>> It's not strictly to this patch, but you can address that
>> later somewhere (just saw it here).
>
> For what it's worth, this issue disappears after the final patch of this series,
> because the other branch reduces to a single line too (all the interrupt_en
> operations are done in the tmu_set_*_temp functions).
That sounds perfect.
I'm planning to build&run the patch set today evening, so I will finish
the review of the patch 9/9.
Powered by blists - more mailing lists