linux-kernel - Re: [PATCH] USB: serial: option: modify Fibocom to DELL custom modem FM101R-GL

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ZVyvxbrCxSos0B6W@hovoldconsulting.com>
Date:   Tue, 21 Nov 2023 14:25:25 +0100
From:   Johan Hovold <johan@...nel.org>
To:     Puliang Lu <puliang.lu@...ocom.com>
Cc:     gregkh@...uxfoundation.org, linux-usb@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] USB: serial: option: modify Fibocom to DELL custom modem
 FM101R-GL

On Thu, Oct 26, 2023 at 08:35:06PM +0800, Puliang Lu wrote:
> Modify the definition of Fibocom USB serial option driver
> FM101R-GL different variants
> 
> - VID:PID 413C:8213, FM101R-GL ESIM are laptop M.2 cards (with
>   MBIM interfaces for Linux)
> 
> - VID:PID 413C:8215, FM101R-GL are laptop M.2 cards (with
>   MBIM interface for Linux)
> 
> 0x8213: mbim, tty
> 0x8215: mbim, tty
> 
> Signed-off-by: Puliang Lu <puliang.lu@...ocom.com>
 
> -#define DELL_PRODUCT_FM101R			0x8213
> -#define DELL_PRODUCT_FM101R_ESIM		0x8215
> +#define DELL_PRODUCT_FM101R_ESIM		0x8213
> +#define DELL_PRODUCT_FM101R				0x8215

You have an extra tab here so that the values are no longer aligned.

>  
>  #define KYOCERA_VENDOR_ID			0x0c88
>  #define KYOCERA_PRODUCT_KPC650			0x17da

Now applied with a slightly updated commit message:

	https://git.kernel.org/pub/scm/linux/kernel/git/johan/usb-serial.git/commit/?h=usb-linus&id=a1092619dd28ac0fcf23016160a2fdccd98ef935

Johan