[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <CAL_JsqJ67tZOmhTHQ7KqEbFuDjK8sKHR1FFtAFAaGjZ4uYi9Uw@mail.gmail.com>
Date: Tue, 21 Nov 2023 07:58:12 -0700
From: Rob Herring <robh@...nel.org>
To: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
Cc: Alim Akhtar <alim.akhtar@...sung.com>,
Conor Dooley <conor+dt@...nel.org>,
linux-arm-kernel@...ts.infradead.org,
linux-samsung-soc@...r.kernel.org, devicetree@...r.kernel.org,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH] arm/arm64: samsung: Enable W=1 on dtbs by default
On Fri, Nov 17, 2023 at 3:19 AM Krzysztof Kozlowski
<krzysztof.kozlowski@...aro.org> wrote:
>
> On 16/11/2023 22:17, Rob Herring wrote:
> > Samsung platforms are clean of W=1 dtc warnings, so enable the warnings
> > by default. This way submitters don't have to remember to run a W=1
> > build of the .dts files and the grumpiness of the maintainers can be
> > reduced.
> >
> > Signed-off-by: Rob Herring <robh@...nel.org>
> > ---
> > Well, there's a couple of warnings on 32-bit, but they look fixable to
> > me.
> >
> > There's a few other platforms we could do this to. Sadly, they are still
> > the minority. Otherwise, we could change the default and add a flag to
> > disable (I_STILL_HAVENT_FIXED_MY_PLATFORMS=1).
>
> 64-bit has still few warnings:
> https://krzk.eu/#/builders/29/builds/3710/steps/26/logs/warnings__6_
I may move that graph check to W=2. There's some cases where port@1 is
optional and it doesn't really make sense to fix these.
Also, Conor wants to do this for all of riscv, but this solution is
per directory. So I need to rework it to use a different variable that
can be per directory or global.
Rob
Powered by blists - more mailing lists