linux-kernel - Re: [PATCH v2 1/5] media: visl: Fix params permissions/defaults mismatch

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 22 Nov 2023 16:56:20 +0100
From:   Hans Verkuil <hverkuil@...all.nl>
To:     Detlev Casanova <detlev.casanova@...labora.com>,
        linux-kernel@...r.kernel.org
Cc:     linux-media@...r.kernel.org,
        Daniel Almeida <daniel.almeida@...labora.com>,
        Mauro Carvalho Chehab <mchehab@...nel.org>
Subject: Re: [PATCH v2 1/5] media: visl: Fix params permissions/defaults
 mismatch

On 24/10/2023 21:09, Detlev Casanova wrote:
> `false` was used as the keep_bitstream_buffers parameter permissions.
> This looks more like a default value for the parameter, so change it to
> 0 to avoid confusion.
> 
> Reviewed-by: Daniel Almeida <daniel.almeida@...labora.com>
> Signed-off-by: Detlev Casanova <detlev.casanova@...labora.com>
> ---
>  drivers/media/test-drivers/visl/visl-core.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/media/test-drivers/visl/visl-core.c b/drivers/media/test-drivers/visl/visl-core.c
> index 9970dc739ca5..df6515530fbf 100644
> --- a/drivers/media/test-drivers/visl/visl-core.c
> +++ b/drivers/media/test-drivers/visl/visl-core.c
> @@ -74,7 +74,7 @@ MODULE_PARM_DESC(visl_dprintk_nframes,
>  		 " the number of frames to trace with dprintk");
>  
>  bool keep_bitstream_buffers;
> -module_param(keep_bitstream_buffers, bool, false);
> +module_param(keep_bitstream_buffers, bool, 0);

???

This last parameter is the permission, it makes no sense that this
is either 0 or false: then nobody can see it in /sys/modules/.

Typically this is 0444 if it is readable only, or 0644 if it can be
written by root.

Regards,

	Hans

>  MODULE_PARM_DESC(keep_bitstream_buffers,
>  		 " keep bitstream buffers in debugfs after streaming is stopped");
>