linux-kernel - Re: [PATCH v2] softlockup: serialized softlockup's log

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAD=FV=Vb12_OKY5Vu1ZWTG6+innP5PkEnHFRPrwj2kOKnHCmag@mail.gmail.com>
Date:   Wed, 22 Nov 2023 08:03:50 -0800
From:   Doug Anderson <dianders@...omium.org>
To:     lizhe.67@...edance.com
Cc:     akpm@...ux-foundation.org, pmladek@...e.com,
        lecopzer.chen@...iatek.com, kernelfans@...il.com,
        linux-kernel@...r.kernel.org, lizefan.x@...edance.com
Subject: Re: [PATCH v2] softlockup: serialized softlockup's log

Hi,

On Wed, Nov 22, 2023 at 2:02 AM <lizhe.67@...edance.com> wrote:
>
> From: Li Zhe <lizhe.67@...edance.com>
>
> If multiple CPUs trigger softlockup at the same time with
> 'softlockup_all_cpu_backtrace=0', the softlockup's logs will appear
> staggeredly in dmesg, which will affect the viewing of the logs for
> developer. Since the code path for outputting softlockup logs is not
> a kernel hotspot and the performance requirements for the code are
> not strict, locks are used to serialize the softlockup log output to
> improve the readability of the logs.
>
> Signed-off-by: Li Zhe <lizhe.67@...edance.com>
> ---
> Changelogs:
>
> v1->v2:
> - define the lock outside the scope of function
> - add precondition 'softlockup_all_cpu_backtrace=0' in commit message
>
>  kernel/watchdog.c | 4 ++++
>  1 file changed, 4 insertions(+)

This seems like a useful improvement to me and the code looks good.

Reviewed-by: Douglas Anderson <dianders@...omium.org>