linux-kernel - [PATCH V2] media: stk1160: Fixed high volume of stk1160

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <20231122161304.12434-1-ghanshyam1898@gmail.com>
Date:   Wed, 22 Nov 2023 21:43:04 +0530
From:   Ghanshyam Agrawal <ghanshyam1898@...il.com>
To:     ezequiel@...guardiasur.com.ar, mchehab@...nel.org
Cc:     Ghanshyam Agrawal <ghanshyam1898@...il.com>,
        linux-media@...r.kernel.org, linux-kernel@...r.kernel.org,
        skhan@...uxfoundation.org,
        linux-kernel-mentees@...ts.linuxfoundation.org,
        Phillip Potter <phil@...lpotter.co.uk>
Subject: [PATCH V2] media: stk1160: Fixed high volume of stk1160_dbg messages

The function stk1160_dbg gets called too many times, which causes
the output to get flooded with messages. Since stk1160_dbg uses
printk, it is now replaced with dev_warn_ratelimited.

Suggested-by: Phillip Potter <phil@...lpotter.co.uk>
Signed-off-by: Ghanshyam Agrawal <ghanshyam1898@...il.com>
---
v2:
Thanks for your suggestions Phillip. I have updated the TODO comment and 
used dev_warn_ratelimited for inclusion of kernel warning.

 drivers/media/usb/stk1160/stk1160-video.c | 12 +++++++++++-
 1 file changed, 11 insertions(+), 1 deletion(-)

diff --git a/drivers/media/usb/stk1160/stk1160-video.c b/drivers/media/usb/stk1160/stk1160-video.c
index f5b75f380c19..a8e0d352a68c 100644
--- a/drivers/media/usb/stk1160/stk1160-video.c
+++ b/drivers/media/usb/stk1160/stk1160-video.c
@@ -105,6 +105,16 @@ void stk1160_copy_video(struct stk1160 *dev, u8 *src, int len)
 	u8 *dst = buf->mem;
 	int remain;
 
+	/*
+	 * TODO: These stk1160_dbg are very spammy!
+	 * We should check why we are getting them.
+	 *
+	 * UPDATE: One of the reasons (the only one?) for getting these
+	 * is incorrect standard (mismatch between expected and configured).
+	 * So perhaps, we could add a counter for errors. When the counter
+	 * reaches some value, we simply stop streaming.
+	 */
+
 	len -= 4;
 	src += 4;
 
@@ -140,7 +150,7 @@ void stk1160_copy_video(struct stk1160 *dev, u8 *src, int len)
 
 	/* Let the bug hunt begin! sanity checks! */
 	if (lencopy < 0) {
-		printk_ratelimited("copy skipped: negative lencopy\n");
+		dev_warn_ratelimited(dev, "copy skipped: negative lencopy\n");
 		return;
 	}
 
-- 
2.25.1