[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <ZV5sEwwnQTjh-QXm@localhost.localdomain>
Date: Wed, 22 Nov 2023 22:01:07 +0100
From: Frederic Weisbecker <frederic@...nel.org>
To: "Rafael J . Wysocki" <rafael@...nel.org>
Cc: LKML <linux-kernel@...r.kernel.org>,
Daniel Lezcano <daniel.lezcano@...aro.org>,
linux-pm@...r.kernel.org
Subject: Re: [PATCH 2/2] cpuidle: Remove unnecessary current_clr_polling() on
poll_idle()
Le Mon, Nov 13, 2023 at 05:03:26PM -0500, Frederic Weisbecker a écrit :
> There is no point in clearing TIF_NR_POLLING and folding TIF_NEED_RESCHED
> upon poll_idle() exit because cpuidle_idle_call() is going to set again
> TIF_NR_POLLING anyway. Also if TIF_NEED_RESCHED is set, it will be
> folded and TIF_NR_POLLING will be cleared at the end of do_idle().
>
> Acked-by: Rafael J. Wysocki <rafael@...nel.org>
> Signed-off-by: Frederic Weisbecker <frederic@...nel.org>
Please discard this one, I'm taking a new way to deal with that.
Thanks.
> ---
> drivers/cpuidle/poll_state.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/cpuidle/poll_state.c b/drivers/cpuidle/poll_state.c
> index 9b6d90a72601..d5cb3eb85a54 100644
> --- a/drivers/cpuidle/poll_state.c
> +++ b/drivers/cpuidle/poll_state.c
> @@ -40,8 +40,6 @@ static int __cpuidle poll_idle(struct cpuidle_device *dev,
> }
> raw_local_irq_disable();
>
> - current_clr_polling();
> -
> return index;
> }
>
> --
> 2.42.1
>
Powered by blists - more mailing lists