linux-kernel - Re: [PATCH v1] USB: gadget: core: adjust uevent timing on gadget unbind

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2023112253-fresh-blazing-baae@gregkh>
Date:   Wed, 22 Nov 2023 22:07:15 +0000
From:   Greg KH <gregkh@...uxfoundation.org>
To:     Roy Luo <royluo@...gle.com>
Cc:     stern@...land.harvard.edu, badhri@...gle.com,
        quic_kriskura@...cinc.com, francesco.dolcini@...adex.com,
        quic_eserrao@...cinc.com, ivan.orlov0322@...il.com,
        linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v1] USB: gadget: core: adjust uevent timing on gadget
 unbind

On Wed, Nov 22, 2023 at 10:00:01PM +0000, Roy Luo wrote:
> The KOBJ_CHANGE uevent is sent before gadget unbind is actually
> executed, resulting in inaccurate uevent emitted at incorrect timing
> (the uevent would have USB_UDC_DRIVER variable set while it would
> soon be removed).
> Move the KOBJ_CHANGE uevent to the end of the unbind function so that
> uevent is sent only after the change has been made.
> 
> Signed-off-by: Roy Luo <royluo@...gle.com>
> ---
>  drivers/usb/gadget/udc/core.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 

What commit does this fix?