linux-kernel - Re: [PATCH v3] mm: ALLOC_HIGHATOMIC flag allocation issue

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZV2dvlKYSDUu6Uit@casper.infradead.org>
Date:   Wed, 22 Nov 2023 06:20:46 +0000
From:   Matthew Wilcox <willy@...radead.org>
To:     Zhiguo Jiang <justinjiang@...o.com>
Cc:     Andrew Morton <akpm@...ux-foundation.org>, linux-mm@...ck.org,
        linux-kernel@...r.kernel.org, Johannes Weiner <hannes@...xchg.org>,
        opensource.kernel@...o.com
Subject: Re: [PATCH v3] mm: ALLOC_HIGHATOMIC flag allocation issue

On Wed, Nov 22, 2023 at 09:39:25AM +0800, Zhiguo Jiang wrote:
> Update base on the latest Linus' tree or Andrew's tree.
> +++ b/mm/page_alloc.c
> @@ -2851,9 +2851,9 @@ struct page *__rmqueue_pcplist(struct zone *zone, unsigned int order,
>  			int alloced;
>  
>  			/*
> -			 * If pcplist is empty and alloc_flags is with ALLOC_HIGHATOMIC,
> -			 * it should alloc from buddy highatomic migrate freelist firstly
> -			 * to ensure quick and successful allocation.
> +			 * If pcplist is empty and alloc_flags contains
> +			 * ALLOC_HIGHATOMIC, alloc from buddy highatomic
> +			 * freelist first.

No, it's still based on your earlier patch,  is it really so hard for
you to read your patches before you send them?