linux-kernel - Re: [PATCH v2 3/8] x86/mm: Remove "static" from vmap_pages

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZV2e/6qTJDkjYbfY@infradead.org>
Date:   Tue, 21 Nov 2023 22:26:07 -0800
From:   Christoph Hellwig <hch@...radead.org>
To:     mhklinux@...look.com
Cc:     tglx@...utronix.de, mingo@...hat.com, bp@...en8.de,
        dave.hansen@...ux.intel.com, x86@...nel.org, hpa@...or.com,
        kirill.shutemov@...ux.intel.com, kys@...rosoft.com,
        haiyangz@...rosoft.com, wei.liu@...nel.org, decui@...rosoft.com,
        luto@...nel.org, peterz@...radead.org, akpm@...ux-foundation.org,
        urezki@...il.com, hch@...radead.org, lstoakes@...il.com,
        thomas.lendacky@....com, ardb@...nel.org, jroedel@...e.de,
        seanjc@...gle.com, rick.p.edgecombe@...el.com,
        sathyanarayanan.kuppuswamy@...ux.intel.com,
        linux-kernel@...r.kernel.org, linux-coco@...ts.linux.dev,
        linux-hyperv@...r.kernel.org, linux-mm@...ck.org
Subject: Re: [PATCH v2 3/8] x86/mm: Remove "static" from vmap_pages_range()

On Tue, Nov 21, 2023 at 01:20:11PM -0800, mhkelley58@...il.com wrote:
> From: Michael Kelley <mhklinux@...look.com>
> 
> The mm subsystem currently provides no mechanism to map memory pages
> to a specified virtual address range.  A virtual address range can be
> allocated using get_vm_area(), but the only function available for
> mapping memory pages to a caller-specified address in that range is
> ioremap_page_range(), which is inappropriate for system memory.
> 
> Fix this by allowing vmap_pages_range() to be used by callers outside
> of vmalloc.c.

I really do not want to expose vmap_pages_range.  Please try to come up
with a good way to encapsulate your map at a certain address primitive
and implement it in vmalloc.c.