linux-kernel - Re: [PATCH v2 5/6] arm: dts: amlogic: migrate pwms to new meson8 v2 binding

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 22 Nov 2023 09:39:39 +0100
From:   Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To:     Jerome Brunet <jbrunet@...libre.com>,
        Thierry Reding <thierry.reding@...il.com>,
        Neil Armstrong <neil.armstrong@...aro.org>,
        Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Conor Dooley <conor+dt@...nel.org>
Cc:     Kevin Hilman <khilman@...libre.com>, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org, linux-amlogic@...ts.infradead.org,
        linux-pwm@...r.kernel.org, JunYi Zhao <junyi.zhao@...ogic.com>
Subject: Re: [PATCH v2 5/6] arm: dts: amlogic: migrate pwms to new meson8 v2
 binding

On 17/11/2023 13:59, Jerome Brunet wrote:
> Update Amlogic based SoC PWMs to meson8-pwm-v2 compatible

Why? Your commit msg must explain this. You break users of this DTS on
older kernels and also this makes it impossible to apply via different
branches in the same cycle. All this needs explanation and proper
justification. Your message tells here nothing, because "what" is quite
obvious.

> 
> Signed-off-by: Jerome Brunet <jbrunet@...libre.com>
> ---
>  arch/arm/boot/dts/amlogic/meson.dtsi           |  4 ++--
>  arch/arm/boot/dts/amlogic/meson8.dtsi          | 16 +++++++++++++---
>  arch/arm/boot/dts/amlogic/meson8b-ec100.dts    |  2 --
>  arch/arm/boot/dts/amlogic/meson8b-mxq.dts      |  2 --
>  arch/arm/boot/dts/amlogic/meson8b-odroidc1.dts |  2 --
>  arch/arm/boot/dts/amlogic/meson8b.dtsi         | 16 +++++++++++++---
>  6 files changed, 28 insertions(+), 14 deletions(-)
> 
> diff --git a/arch/arm/boot/dts/amlogic/meson.dtsi b/arch/arm/boot/dts/amlogic/meson.dtsi
> index 8e3860d5d916..80cc004ad5fe 100644
> --- a/arch/arm/boot/dts/amlogic/meson.dtsi
> +++ b/arch/arm/boot/dts/amlogic/meson.dtsi
> @@ -83,14 +83,14 @@ i2c_A: i2c@...0 {
>  			};
>  
>  			pwm_ab: pwm@...0 {
> -				compatible = "amlogic,meson-pwm";
> +				compatible = "amlogic,meson8-pwm-v2";

That's breaking users of this DTS (old kernel, out of tree, other
projects) for no real reasons without explanation.

Best regards,
Krzysztof