linux-kernel - Re: [PATCH 0/5] staging: media: av7110: Fix various formatting and small code issues

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <6e0ade60-9382-4df2-8fb0-368957a154ea@xs4all.nl>
Date:   Wed, 22 Nov 2023 11:57:12 +0100
From:   Hans Verkuil <hverkuil@...all.nl>
To:     Jonathan Bergh <bergh.jonathan@...il.com>, mchehab@...nel.org
Cc:     gregkh@...uxfoundation.org, error27@...il.com,
        linux-staging@...ts.linux.dev, linux-media@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 0/5] staging: media: av7110: Fix various formatting and
 small code issues

Hi Jonathan,

On 21/10/2023 01:23, Jonathan Bergh wrote:
> These patches cover various formatting and small code issues. Formatting
> issues include missing newlines, whitespace and miscellaneous formatting 
> issues. The series also fixes small code issues including using preferred 
> integer types ('long' instead of 'long int') and ('unsigned int' instead 
> of 'unsigned').
> 
> Jonathan Bergh (5):
>   staging: media: av7110: Fix missing newlines after declaration
>     warnings
>   staging: media: av7110: Fix various whitespace checkpatch errors
>   staging: media: av7110: Remove unnecessary whitespace before quoted
>     newlines
>   staging: media: av7110: Fix 'long int' and 'unsigned' variable
>     declarations
>   staging: media: av7110: Fix various formating issues
> 
>  drivers/staging/media/av7110/av7110_av.c | 114 +++++++++++++----------
>  1 file changed, 64 insertions(+), 50 deletions(-)
> 

For future reference: when looking at staging drivers always check the
TODO file. In this case see drivers/staging/media/av7110/TODO:

- This driver is too old and relies on a different API.
  Drop it from Kernel on a couple of versions.
- Cleanup patches for the drivers here won't be accepted.

So I'll just drop these cleanup patches.

Regards,

	Hans