linux-kernel - Re: [PATCH v6 4/7] iommu: Decouple iommu_domain

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <719ab0c1-e2a8-4446-8b3f-ba751db0ce27@linux.intel.com>
Date:   Wed, 22 Nov 2023 09:51:27 +0800
From:   Baolu Lu <baolu.lu@...ux.intel.com>
To:     Robin Murphy <robin.murphy@....com>, joro@...tes.org,
        will@...nel.org
Cc:     baolu.lu@...ux.intel.com, iommu@...ts.linux.dev, jgg@...dia.com,
        linux-kernel@...r.kernel.org, jsnitsel@...hat.com
Subject: Re: [PATCH v6 4/7] iommu: Decouple iommu_domain_alloc() from bus ops

On 11/22/23 2:04 AM, Robin Murphy wrote:
> As the final remaining piece of bus-dependent API, iommu_domain_alloc()
> can now take responsibility for the "one iommu_ops per bus" rule for
> itself. It turns out we can't safely make the internal allocation call
> any more group-based or device-based yet - that will have to wait until
> the external callers can pass the right thing - but we can at least get
> as far as deriving "bus ops" based on which driver is actually managing
> devices on the given bus, rather than whichever driver won the race to
> register first.
> 
> This will then leave us able to convert the last of the core internals
> over to the IOMMU-instance model, allow multiple drivers to register and
> actually coexist (modulo the above limitation for unmanaged domain users
> in the short term), and start trying to solve the long-standing
> iommu_probe_device() mess.
> 
> Reviewed-by: Jason Gunthorpe<jgg@...dia.com>
> Reviewed-by: Jerry Snitselaar<jsnitsel@...hat.com>
> Signed-off-by: Robin Murphy<robin.murphy@....com>
> 
> ---
> 
> v5: Rewrite, de-scoping to just retrieve ops under the same assumptions
>      as the existing code.
> ---
>   drivers/iommu/iommu.c | 25 ++++++++++++++++++++++---
>   1 file changed, 22 insertions(+), 3 deletions(-)

Reviewed-by: Lu Baolu <baolu.lu@...ux.intel.com>

Best regards,
baolu