linux-kernel - Re: [PATCH 2/2] phy: qcom: snps-eusb2: Add X1E80100 Compatible

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1d224284-7d8e-4f4e-a911-13fdfd54238b@linaro.org>
Date:   Wed, 22 Nov 2023 13:10:35 +0100
From:   Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To:     Dmitry Baryshkov <dmitry.baryshkov@...aro.org>,
        Abel Vesa <abel.vesa@...aro.org>
Cc:     Andy Gross <agross@...nel.org>,
        Bjorn Andersson <andersson@...nel.org>,
        Konrad Dybcio <konrad.dybcio@...aro.org>,
        Vinod Koul <vkoul@...nel.org>,
        Kishon Vijay Abraham I <kishon@...nel.org>,
        Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Conor Dooley <conor+dt@...nel.org>,
        linux-arm-msm@...r.kernel.org, linux-phy@...ts.infradead.org,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/2] phy: qcom: snps-eusb2: Add X1E80100 Compatible

On 22/11/2023 12:01, Dmitry Baryshkov wrote:
> On Wed, 22 Nov 2023 at 12:28, Abel Vesa <abel.vesa@...aro.org> wrote:
>>
>> Add the X1E80100 to the list of supported PHYs for eUSB2
>> SNPS driver.
>>
>> Signed-off-by: Abel Vesa <abel.vesa@...aro.org>
>> ---
>>  drivers/phy/qualcomm/phy-qcom-snps-eusb2.c | 1 +
>>  1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/phy/qualcomm/phy-qcom-snps-eusb2.c b/drivers/phy/qualcomm/phy-qcom-snps-eusb2.c
>> index 1484691a41d5..6420f342dc85 100644
>> --- a/drivers/phy/qualcomm/phy-qcom-snps-eusb2.c
>> +++ b/drivers/phy/qualcomm/phy-qcom-snps-eusb2.c
>> @@ -425,6 +425,7 @@ static int qcom_snps_eusb2_hsphy_probe(struct platform_device *pdev)
>>
>>  static const struct of_device_id qcom_snps_eusb2_hsphy_of_match_table[] = {
>>         { .compatible = "qcom,sm8550-snps-eusb2-phy", },
>> +       { .compatible = "qcom,x1e80100-snps-eusb2-phy", },
> 
> Do we need a separate compatible string or is it fully compatible with
> sm8550? If it is the same IP block, maybe you can use a fallback
> compatible instead?

Yep. This should use fallback.

Best regards,
Krzysztof