linux-kernel - Re: [PATCH] crypto: hisilicon - Add check for pci_find_ext

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <450d30a4-5b01-6e20-3fd7-bee0cead419f@huawei.com>
Date:   Wed, 22 Nov 2023 20:11:37 +0800
From:   Weili Qian <qianweili@...wei.com>
To:     Herbert Xu <herbert@...dor.apana.org.au>
CC:     Chen Ni <nichen@...as.ac.cn>, <wangzhou1@...ilicon.com>,
        <davem@...emloft.net>, <xuzaibo@...wei.com>,
        <tanshukun1@...wei.com>, <linux-crypto@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] crypto: hisilicon - Add check for pci_find_ext_capability



On 2023/11/17 18:36, Herbert Xu wrote:
> On Fri, Nov 17, 2023 at 10:07:00AM +0800, Weili Qian wrote:
>>
>> Thanks for your patch. The function qm_set_vf_mse() is called only after SRIOV
>> is enabled, so function pci_find_ext_capability() does not return 0. This check
>> makes no sense.
> 
> Perhaps we could add a comment instead?
> 
> Thanks,
> 

Okay, I will add a comment for this.

Thanks,
Weili