linux-kernel - Re: [PATCH 2/2] dt-bindings: iio: temperature: add MLX90635 device bindings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ea997987-6a84-445c-a806-527d766569b1@kernel.org>
Date:   Wed, 22 Nov 2023 13:35:19 +0100
From:   Krzysztof Kozlowski <krzk@...nel.org>
To:     Crt Mori <cmo@...exis.com>
Cc:     Jonathan Cameron <jic23@...nel.org>,
        Rob Herring <robh+dt@...nel.org>, linux-iio@...r.kernel.org,
        linux-kernel@...r.kernel.org, devicetree@...r.kernel.org
Subject: Re: [PATCH 2/2] dt-bindings: iio: temperature: add MLX90635 device
 bindings

On 22/11/2023 13:28, Crt Mori wrote:
>>> +  Since measured object emissivity effects Infra Red energy emitted,
>>> +  emissivity should be set before requesting the object temperature.
>>> +
>>> +properties:
>>> +  compatible:
>>> +    const: melexis,mlx90635
>>
>> It's the same as mlx90632. Add it there (as enum).
>>
> 
> Properties are the same, but then you can't have much differences for
> a temperature sensor. It has a bit worse relative measurement error
> outside of the human body range and overall different DSP, register
> map, even physical size - it's 1.8x1.8 mm compared to 90632 3x3 mm. I
> was not sure how it qualifies for adding it as another enum, but I
> went with the feeling that if it can reuse the driver, then it is an
> enum, otherwise it is a new file. And I could not reuse anything from
> 90632.
> 
> Thanks for quick feedback and best regards,

Driver is independent choice. There is no need for new binding file if
everything is the same from bindings point of view.

Best regards,
Krzysztof