linux-kernel - Re: [PATCH v5 19/39] mtd: rawnand: add support for ts72xx

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20231122140803.239a3c17@xps-13>
Date:   Wed, 22 Nov 2023 14:08:03 +0100
From:   Miquel Raynal <miquel.raynal@...tlin.com>
To:     Andy Shevchenko <andriy.shevchenko@...el.com>
Cc:     Nikita Shubin <nikita.shubin@...uefel.me>,
        Richard Weinberger <richard@....at>,
        Vignesh Raghavendra <vigneshr@...com>,
        Arnd Bergmann <arnd@...db.de>,
        Linus Walleij <linus.walleij@...aro.org>,
        Neil Armstrong <neil.armstrong@...aro.org>,
        Daniel Golle <daniel@...rotopia.org>,
        Jean Delvare <jdelvare@...e.de>,
        Christophe Kerello <christophe.kerello@...s.st.com>,
        Chris Packham <chris.packham@...iedtelesis.co.nz>,
        Johan Jonker <jbx6244@...il.com>, linux-kernel@...r.kernel.org,
        linux-mtd@...ts.infradead.org,
        Alexander Sverdlin <alexander.sverdlin@...il.com>
Subject: Re: [PATCH v5 19/39] mtd: rawnand: add support for ts72xx

Hi Andy,

> > +	int ret;
> > +
> > +	ret = mtd_device_unregister(nand_to_mtd(chip));
> > +	WARN_ON(ret);  
> 
> Is this a requirement by MTD to have return value being checked?

Yes, for now this is the preferred way, with the hope some day to turn
the return value into void.

Thanks,
Miquèl