linux-kernel - Re: [PATCH 0/2] media: imx-mipi-csis: csis clock fixes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <61de2617-fdc2-4f0c-8ffc-5dfc99b825e7@ideasonboard.com>
Date:   Wed, 22 Nov 2023 15:44:33 +0200
From:   Tomi Valkeinen <tomi.valkeinen@...asonboard.com>
To:     Fabio Estevam <festevam@...il.com>
Cc:     Kieran Bingham <kieran.bingham@...asonboard.com>,
        Rui Miguel Silva <rmfrfs@...il.com>,
        Laurent Pinchart <laurent.pinchart@...asonboard.com>,
        Martin Kepplinger <martink@...teo.de>,
        Purism Kernel Team <kernel@...i.sm>,
        Mauro Carvalho Chehab <mchehab@...nel.org>,
        Shawn Guo <shawnguo@...nel.org>,
        Sascha Hauer <s.hauer@...gutronix.de>,
        Pengutronix Kernel Team <kernel@...gutronix.de>,
        NXP Linux Team <linux-imx@....com>,
        linux-media@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 0/2] media: imx-mipi-csis: csis clock fixes

On 22/11/2023 15:21, Fabio Estevam wrote:
> Hi Tomi,
> 
> On Wed, Nov 22, 2023 at 10:14 AM Tomi Valkeinen
> <tomi.valkeinen@...asonboard.com> wrote:
>>
>> Two fixes to the csis driver: One to fix remove() another to only enable
>> the clocks when needed.
>>
>> Signed-off-by: Tomi Valkeinen <tomi.valkeinen@...asonboard.com>
>> ---
>> Tomi Valkeinen (2):
>>        media: imx-mipi-csis: Fix clock handling in remove()
>>        media: imx-mipi-csis: Drop extra clock enable at probe()
> 
> Shouldn't both patches contain a Fixes tag?

I think the issue is there in the original commit adding the driver:

7807063b862b ("media: staging/imx7: add MIPI CSI-2 receiver subdev for 
i.MX7")

However, the driver has changed along the way, and I'm not sure if the 
original one had an actual bug. Nevertheless, the same pattern (wrt. 
clocks and runtime) is there in the original one, and I think that 
pattern is not correct even if it wouldn't have caused any visible issue.

So I'll add that commit as Fixes-tag, but if someone with more knowledge 
about the driver can verify this, that'd be great.

  Tomi