linux-kernel - Re: [PATCH v11 2/3] media: rockchip: Add a driver for Rockchip's camera interface

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZV4KB7/TO66if41o@pc-70.home>
Date:   Wed, 22 Nov 2023 15:02:47 +0100
From:   Mehdi Djait <mehdi.djait@...tlin.com>
To:     Paul Kocialkowski <paul.kocialkowski@...tlin.com>
Cc:     Michael Riesch <michael.riesch@...fvision.net>,
        Tommaso Merciai <tomm.merciai@...il.com>, mchehab@...nel.org,
        heiko@...ech.de, hverkuil-cisco@...all.nl,
        krzysztof.kozlowski+dt@...aro.org, robh+dt@...nel.org,
        conor+dt@...nel.org, linux-media@...r.kernel.org,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
        thomas.petazzoni@...tlin.com, alexandre.belloni@...tlin.com,
        maxime.chevallier@...tlin.com
Subject: Re: [PATCH v11 2/3] media: rockchip: Add a driver for Rockchip's
 camera interface

Hello everyone,

> > >>  create mode 100644 drivers/media/platform/rockchip/cif/Kconfig
> > >>  create mode 100644 drivers/media/platform/rockchip/cif/Makefile
> > >>  create mode 100644 drivers/media/platform/rockchip/cif/capture.c
> > >>  create mode 100644 drivers/media/platform/rockchip/cif/capture.h
> > >>  create mode 100644 drivers/media/platform/rockchip/cif/common.h
> > >>  create mode 100644 drivers/media/platform/rockchip/cif/dev.c
> > >>  create mode 100644 drivers/media/platform/rockchip/cif/regs.h
> > > 
> > > Just a logigistic comment on my side for now, sorry :)
> > > What about use cif-* prefix in front of driver files?
> > > 
> > > like:
> > > 
> > > cif-capture.c
> > > cif-capture.h
> > > cif-common.h
> > > cif-dev.c
> > > cif-regs.h
> > 
> > What would be the rationale here?
> > 
> > IMHO the files are in a folder named cif, so adding this prefix seems
> > kind of redundant.
> > 
> > That said, if there is a good reason I could live with cif-*.{c,h} as
> > well, of course. My only request would be to agree on something ASAP.
> 
> It's rather common to do that in Linux and one advantage is that it makes it
> clear in your text editor which driver you are looking at when only the file
> name is shown.
> 
> I don't have any strong opinion on this either though.

I see that the majority of the drivers are named like suggested. I will
change the names in the V12.

--
Kind Regards
Mehdi Djait