linux-kernel - Re: [PATCH v4] dt-bindings: leds: add 'internet' and 'signal' function definitions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <6d1a0be4-89b3-4c47-8763-4139904cc670@lunn.ch>
Date:   Thu, 23 Nov 2023 16:45:11 +0100
From:   Andrew Lunn <andrew@...n.ch>
To:     Lee Jones <lee@...nel.org>
Cc:     Shiji Yang <yangshiji66@...look.com>,
        Florian Fainelli <f.fainelli@...il.com>,
        linux-leds@...r.kernel.org, devicetree@...r.kernel.org,
        Pavel Machek <pavel@....cz>, Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Conor Dooley <conor+dt@...nel.org>,
        Jisheng Zhang <jszhang@...nel.org>,
        linux-kernel@...r.kernel.org, netdev@...r.kernel.org
Subject: Re: [PATCH v4] dt-bindings: leds: add 'internet' and 'signal'
 function definitions

On Thu, Nov 23, 2023 at 11:25:43AM +0000, Lee Jones wrote:
> Andrew, Florian,
> 
> Thoughts?

Hi Lee

Thanks for forwarding this.

> On Mon, 06 Nov 2023, Shiji Yang wrote:
> 
> > These two types of LEDs are widely used in routers and NICs.

I would disagree with this. Routers and NICs are very generic
terms. The Cisco router i have in the broom closet does not have a
signal strength. It does not even have WiFi. It has no concept of
Internet.

I would drop NIC and add more words to narrow routers down to a more
specific class of routers, probably those found in homes, rented from
an ISP, most don't actually do L3 routing, or at best, just NAT.

> > The 'signal' LED is used to display the wireless signal strength.
> > Usually, there are 3~4 LEDs in one group to indicate the signal
> > strength, similar to the signal icon on a mobile phone.

Maybe signal_strength. And is there any reason these cannot be used on
a 5G modem to indicate 'mobile phone' like signal strength? So
`similar to` is wrong, they could actually be used for that.

At least the word wireless is used, not wifi. So its reasonably
generic. Are there other signal strength indicators for other media?
I've not seen powerline modems have such indicators. And with those
SNR is more important than signal strength.

> > The 'internet' LED can indicate whether the device can access a
> > specific server. It's different from 'wan'. 'wan' usually indicates
> > whether the WAN port is connected to the modem (internet services
> > may still be unavailable). But the 'internet' shows if the device
> > can successfully ping servers such as 8.8.8.8 to detect the internet
> > connection status. When the router is running in AP only mode, we
> > can even connect LAN port to the AC/modem to connect to the internet.
> > In this case, the 'internet' LED should be on. On some routers, both
> > 'internet' and 'wan' are available and can be controlled separately.

I suggest some of this text appears in the header, to make their
meaning clear. Also, document what WAN means. But care is needed,
since these are networking wide concepts, not the very narrow market
of an ISP rented boxes.

    Andrew