linux-kernel - RE: [PATCH v3] drm/bridge: panel: Add a device link between drm device and panel device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <DB8PR04MB7051671F64456C0675B64CD398B9A@DB8PR04MB7051.eurprd04.prod.outlook.com>
Date:   Thu, 23 Nov 2023 03:14:41 +0000
From:   Ying Liu <victor.liu@....com>
To:     Linus Walleij <linus.walleij@...aro.org>
CC:     "dri-devel@...ts.freedesktop.org" <dri-devel@...ts.freedesktop.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "andrzej.hajda@...el.com" <andrzej.hajda@...el.com>,
        "neil.armstrong@...aro.org" <neil.armstrong@...aro.org>,
        "rfoss@...nel.org" <rfoss@...nel.org>,
        "Laurent.pinchart@...asonboard.com" 
        <Laurent.pinchart@...asonboard.com>,
        "jonas@...boo.se" <jonas@...boo.se>,
        "jernej.skrabec@...il.com" <jernej.skrabec@...il.com>,
        "airlied@...il.com" <airlied@...il.com>,
        "daniel@...ll.ch" <daniel@...ll.ch>,
        Ulf Hansson <ulf.hansson@...aro.org>
Subject: RE: [PATCH v3] drm/bridge: panel: Add a device link between drm
 device and panel device

On Wednesday, November 22, 2023 9:59 PM, Linus Walleij <linus.walleij@...aro.org> wrote:
> Hi Ying,

Hi Linus,

> 
> On Mon, Nov 20, 2023 at 11:08 AM Ying Liu <victor.liu@....com> wrote:
> 
> [Me]
> > > > v2->v3:
> > > > * Improve commit message s/swapped/reversed/.
> > >
> > > This patch causes a regression in the Ux500 MCDE
> > > drivers/gpu/drm/mcde/* driver with the nt35510 panel
> > > drivers/gpu/drm/panel/panel-novatek-nt35510.c
> > > my dmesg looks like this:
> (...)
> > Sorry for the breakage and a bit late response(I'm a bit busy with internal
> > things).
> >
> > I think device_link_add() fails because a0351000.dsi.0 already depends
> > on a0350000.mcde.  Can you confirm that device_link_add() returns NULL
> > right after it calls device_is_dependent()?
> >
> > Does this patch fix the issue?
> 
> Yep it works!
> 
> You missed one device_link_del() instance on the errorpath.

Will add it.

> 
> Tested-by: Linus Walleij <linus.walleij@...aro.org>

Thanks for the test.

> 
> Can you send it as a proper patch?

Will do.

Regards,
Liu Ying