linux-kernel - Re: [PATCH] mptcp: fix uninit-value in mptcp_incoming

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <c1f1f869346f4d6fc90eac6d131454b85fa676be.camel@redhat.com>
Date:   Thu, 23 Nov 2023 17:41:31 +0100
From:   Paolo Abeni <pabeni@...hat.com>
To:     Edward Adam Davis <eadavis@...com>,
        syzbot+b834a6b2decad004cfa1@...kaller.appspotmail.com
Cc:     davem@...emloft.net, edumazet@...gle.com, kuba@...nel.org,
        linux-kernel@...r.kernel.org, martineau@...nel.org,
        matthieu.baerts@...sares.net, matttbe@...nel.org,
        mptcp@...ts.linux.dev, netdev@...r.kernel.org,
        syzkaller-bugs@...glegroups.com
Subject: Re: [PATCH] mptcp: fix uninit-value in mptcp_incoming_options

On Thu, 2023-11-23 at 09:23 +0800, Edward Adam Davis wrote:
> Added initialization use_ack to mptcp_parse_option().
> 
> Reported-by: syzbot+b834a6b2decad004cfa1@...kaller.appspotmail.com
> Signed-off-by: Edward Adam Davis <eadavis@...com>
> ---
>  net/mptcp/options.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/net/mptcp/options.c b/net/mptcp/options.c
> index cd15ec73073e..c53914012d01 100644
> --- a/net/mptcp/options.c
> +++ b/net/mptcp/options.c
> @@ -108,6 +108,7 @@ static void mptcp_parse_option(const struct sk_buff *skb,
>  			mp_opt->suboptions |= OPTION_MPTCP_DSS;
>  			mp_opt->use_map = 1;
>  			mp_opt->mpc_map = 1;
> +			mp_opt->use_ack = 0;
>  			mp_opt->data_len = get_unaligned_be16(ptr);
>  			ptr += 2;
>  		}

LGTM, and syzbot tested it.

Acked-by: Paolo Abeni <pabeni@...hat.com>

@Edward: for future similar patches, please add also the tested tag
from syzbot, will make tracking easier.

Thanks!

Paolo