[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <CAPDyKFqjcP2pAH8uo61Yc7wU76NM1aCMN6P1TaAoafCFfZSeWw@mail.gmail.com>
Date: Thu, 23 Nov 2023 18:13:09 +0100
From: Ulf Hansson <ulf.hansson@...aro.org>
To: Pin-yen Lin <treapking@...omium.org>
Cc: Chaotian Jing <chaotian.jing@...iatek.com>,
Matthias Brugger <matthias.bgg@...il.com>,
AngeloGioacchino Del Regno
<angelogioacchino.delregno@...labora.com>,
linux-kernel@...r.kernel.org, linux-mediatek@...ts.infradead.org,
Chen-Yu Tsai <wenst@...omium.org>,
ot_shunxi.zhang@...iatek.corp-partner.google.com,
linux-arm-kernel@...ts.infradead.org, linux-mmc@...r.kernel.org
Subject: Re: [PATCH] mmc: mtk-sd: Increase the verbosity of msdc_track_cmd_data
On Fri, 17 Nov 2023 at 10:55, Pin-yen Lin <treapking@...omium.org> wrote:
>
> This log message is necessary for debugging, so enable it by default to
> debug issues that are hard to reproduce locally.
>
> Signed-off-by: Pin-yen Lin <treapking@...omium.org>
>
> ---
>
> drivers/mmc/host/mtk-sd.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mmc/host/mtk-sd.c b/drivers/mmc/host/mtk-sd.c
> index 97f7c3d4be6e..4469003f571e 100644
> --- a/drivers/mmc/host/mtk-sd.c
> +++ b/drivers/mmc/host/mtk-sd.c
> @@ -1150,7 +1150,7 @@ static void msdc_recheck_sdio_irq(struct msdc_host *host)
> static void msdc_track_cmd_data(struct msdc_host *host, struct mmc_command *cmd)
> {
> if (host->error)
> - dev_dbg(host->dev, "%s: cmd=%d arg=%08X; host->error=0x%08X\n",
> + dev_err(host->dev, "%s: cmd=%d arg=%08X; host->error=0x%08X\n",
> __func__, cmd->opcode, cmd->arg, host->error);
How critical is this? Should we perhaps use a dev_warn instead?
> }
>
Kind regards
Uffe
Powered by blists - more mailing lists