linux-kernel - Re: [PATCH v3 5/5] staging: rtl8192e: renamed variable HTIOTActIsMgntUseCCK6M

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4df855f1-77e9-44a2-a024-aa5c7d661642@gmail.com>
Date:   Thu, 23 Nov 2023 22:05:34 +0100
From:   Philipp Hortmann <philipp.g.hortmann@...il.com>
To:     Gary Rookard <garyrookard@...tmail.org>, gregkh@...uxfoundation.org
Cc:     linux-staging@...ts.linux.dev, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3 5/5] staging: rtl8192e: renamed variable
 HTIOTActIsMgntUseCCK6M

On 11/23/23 15:43, Gary Rookard wrote:
> Renamed from Pascal/CamelCase to Snake case the variable
> HTIOTActIsMgntUseCCK6M.
> HTIOTActIsMgntUseCCK6M -> ht_iot_act_is_mgnt_use_cck_6m
> 
> Linux kernel coding style (cleanup), checkpatch Avoid CamelCase.
> Driver/module rtl8192e compiles.
> 
> Signed-off-by: Gary Rookard <garyrookard@...tmail.org>
> ---
> v3: Corrected versioning fron v1 -> v3, includes change history.
> v2: v2 was Skipped over..v3 corrects this.
> v1: Style and compile issues, asked to redo.
> 
>   drivers/staging/rtl8192e/rtl819x_HTProc.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/staging/rtl8192e/rtl819x_HTProc.c b/drivers/staging/rtl8192e/rtl819x_HTProc.c
> index 0873c19ca051..f43249fd78d7 100644
> --- a/drivers/staging/rtl8192e/rtl819x_HTProc.c
> +++ b/drivers/staging/rtl8192e/rtl819x_HTProc.c
> @@ -207,7 +207,7 @@ static void ht_iot_peer_determine(struct rtllib_device *ieee)
>   	netdev_dbg(ieee->dev, "IOTPEER: %x\n", ht_info->IOTPeer);
>   }
>   
> -static u8 HTIOTActIsMgntUseCCK6M(struct rtllib_device *ieee,
> +static u8 ht_iot_act_is_mgnt_use_cck_6m(struct rtllib_device *ieee,
>   				 struct rtllib_network *network)

CHECK: Alignment should match open parenthesis
#33: FILE: drivers/staging/rtl8192e/rtl819x_HTProc.c:211:
+static u8 ht_iot_act_is_mgnt_use_cck_6m(struct rtllib_device *ieee,
  				 struct rtllib_network *network)

Please use checkpatch on your patches. Alignment issues can be fixed up 
by you. CamelCase oft not when the variable did not change within your 
patch.

>   {
>   	u8	retValue = 0;
> @@ -675,7 +675,7 @@ void HTResetSelfAndSavePeerSetting(struct rtllib_device *ieee,
>   		ht_iot_peer_determine(ieee);
>   
>   		ht_info->iot_action = 0;
> -		bIOTAction = HTIOTActIsMgntUseCCK6M(ieee, pNetwork);
> +		bIOTAction = ht_iot_act_is_mgnt_use_cck_6m(ieee, pNetwork);
>   		if (bIOTAction)
>   			ht_info->iot_action |= HT_IOT_ACT_MGNT_USE_CCK_6M;
>   		bIOTAction = HTIOTActIsCCDFsync(ieee);