[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <0cee5543-711d-3d6e-f416-18889badff18@axentia.se>
Date: Fri, 24 Nov 2023 00:10:53 +0100
From: Peter Rosin <peda@...ntia.se>
To: Heiner Kallweit <hkallweit1@...il.com>,
Wolfram Sang <wsa@...nel.org>,
Andi Shyti <andi.shyti@...nel.org>
Cc: linux-i2c@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 05/10] drivers/i2c/busses: Don't let i2c adapters declare
I2C_CLASS_SPD support if they support I2C_CLASS_HWMON
Hi!
2023-11-18 at 19:04, Heiner Kallweit wrote:
> diff --git a/drivers/i2c/busses/i2c-kempld.c b/drivers/i2c/busses/i2c-kempld.c
> index e01d75308..9076ae4d7 100644
> --- a/drivers/i2c/busses/i2c-kempld.c
> +++ b/drivers/i2c/busses/i2c-kempld.c
> @@ -283,8 +283,8 @@ static const struct i2c_algorithm kempld_i2c_algorithm = {
> static const struct i2c_adapter kempld_i2c_adapter = {
> .owner = THIS_MODULE,
> .name = "i2c-kempld",
> - .class = I2C_CLASS_HWMON | I2C_CLASS_SPD |
> - I2C_CLASS_DEPRECATED,
> + .class = I2C_CLASS_HWMON |
> + I2C_CLASS_DEPRECATED,
The above is less than ideal...
It should obviously be:
- .class = I2C_CLASS_HWMON | I2C_CLASS_SPD |
- I2C_CLASS_DEPRECATED,
+ .class = I2C_CLASS_HWMON | I2C_CLASS_DEPRECATED,
Cheers,
Peter
Powered by blists - more mailing lists