linux-kernel - [PATCH 1/1] ntp: Refine ntp_get_next

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:   Thu, 23 Nov 2023 12:08:18 +0800
From:   Adrian Huang <adrianhuang0701@...il.com>
To:     linux-kernel@...r.kernel.org
Cc:     John Stultz <jstultz@...gle.com>,
        Thomas Gleixner <tglx@...utronix.de>,
        Stephen Boyd <sboyd@...nel.org>,
        Adrian Huang <adrianhuang0701@...il.com>,
        Adrian Huang <ahuang12@...ovo.com>
Subject: [PATCH 1/1] ntp: Refine ntp_get_next_leap implementation

From: Adrian Huang <ahuang12@...ovo.com>

It is unnecessary to use the local variable 'ret' in the ntp_get_next_leap
implementation function - just return KTIME_MAX directly and get rid of
the local variable altogether.

Signed-off-by: Adrian Huang <ahuang12@...ovo.com>
---
 kernel/time/ntp.c | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/kernel/time/ntp.c b/kernel/time/ntp.c
index 406dccb79c2b..af1a7e0c0f9d 100644
--- a/kernel/time/ntp.c
+++ b/kernel/time/ntp.c
@@ -379,12 +379,10 @@ u64 ntp_tick_length(void)
  */
 ktime_t ntp_get_next_leap(void)
 {
-	ktime_t ret;
-
 	if ((time_state == TIME_INS) && (time_status & STA_INS))
 		return ktime_set(ntp_next_leap_sec, 0);
-	ret = KTIME_MAX;
-	return ret;
+
+	return KTIME_MAX;
 }
 
 /*
-- 
2.25.1