linux-kernel - Re: [Patch v2] thunderbolt: Add quirk to reset downstream port

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20231123060004.GA1074920@black.fi.intel.com>
Date:   Thu, 23 Nov 2023 08:00:04 +0200
From:   Mika Westerberg <mika.westerberg@...ux.intel.com>
To:     Mario Limonciello <mario.limonciello@....com>
Cc:     Sanath S <Sanath.S@....com>, andreas.noever@...il.com,
        michael.jamet@...el.com, YehezkelShB@...il.com,
        linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org,
        stable@...r.kernel.org
Subject: Re: [Patch v2] thunderbolt: Add quirk to reset downstream port

On Wed, Nov 22, 2023 at 09:43:55AM -0600, Mario Limonciello wrote:
> On 11/22/2023 00:03, Mika Westerberg wrote:
> > Hi,
> > 
> > On Wed, Nov 22, 2023 at 10:36:39AM +0530, Sanath S wrote:
> > > Boot firmware on AMD's Yellow Carp and Pink Sardine allocates
> > > very minimal buses for PCIe downstream ports. This results in
> > > failure to extend the daisy chain.
> > > 
> > > Add quirk to reset the downstream port to help reset the topology
> > > created by boot firmware.
> > 
> > But this resets the USB4 side of ports, how does this help with the PCIe
> > side? Or this also resets the PCIe side? Please add this information to
> > the changelog too.
> 
> IIUC the PCIe side will be implicitly reset as well.
> 
> > 
> > I suppose it is not possible to fix the boot firmware?
> 
> It's a really difficult case to make with firmware team.  Windows and Linux
> have a different behavior here.  The Windows CM doesn't take the existing
> tunnels from firmware and instead always resets them.
> So Windows "isn't affected" by this problem.
> 
> Furthermore there are already lots of systems out "in the wild" as these are
> already both production silicon with shipping OEM products.

Yeah that's what I was afraid :( Okay we've been there before so let's
work it around in the kernel then.