linux-kernel - RE: [PATCH] drm/i915/psr: Fix unsigned expression compared with zero

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <MW4PR11MB70543D88DB824C6C2821B2FBEFB9A@MW4PR11MB7054.namprd11.prod.outlook.com>
Date:   Thu, 23 Nov 2023 07:06:50 +0000
From:   "Kahola, Mika" <mika.kahola@...el.com>
To:     Jani Nikula <jani.nikula@...ux.intel.com>,
        Jiapeng Chong <jiapeng.chong@...ux.alibaba.com>
CC:     "joonas.lahtinen@...ux.intel.com" <joonas.lahtinen@...ux.intel.com>,
        "Vivi, Rodrigo" <rodrigo.vivi@...el.com>,
        "tvrtko.ursulin@...ux.intel.com" <tvrtko.ursulin@...ux.intel.com>,
        "airlied@...il.com" <airlied@...il.com>,
        "daniel@...ll.ch" <daniel@...ll.ch>,
        "intel-gfx@...ts.freedesktop.org" <intel-gfx@...ts.freedesktop.org>,
        "dri-devel@...ts.freedesktop.org" <dri-devel@...ts.freedesktop.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Jiapeng Chong <jiapeng.chong@...ux.alibaba.com>,
        Abaci Robot <abaci@...ux.alibaba.com>
Subject: RE: [PATCH] drm/i915/psr: Fix unsigned expression compared with zero

> -----Original Message-----
> From: Jani Nikula <jani.nikula@...ux.intel.com>
> Sent: Wednesday, November 22, 2023 11:15 AM
> To: Jiapeng Chong <jiapeng.chong@...ux.alibaba.com>
> Cc: joonas.lahtinen@...ux.intel.com; Vivi, Rodrigo <rodrigo.vivi@...el.com>; tvrtko.ursulin@...ux.intel.com; airlied@...il.com;
> daniel@...ll.ch; intel-gfx@...ts.freedesktop.org; dri-devel@...ts.freedesktop.org; linux-kernel@...r.kernel.org; Jiapeng Chong
> <jiapeng.chong@...ux.alibaba.com>; Abaci Robot <abaci@...ux.alibaba.com>; Kahola, Mika <mika.kahola@...el.com>
> Subject: Re: [PATCH] drm/i915/psr: Fix unsigned expression compared with zero
> 
> On Wed, 22 Nov 2023, Jiapeng Chong <jiapeng.chong@...ux.alibaba.com> wrote:
> > The entry_setup_frames is defined as u8 type, else(entry_setup_frames
> > < 0) is invalid. At the same time, the return value of function
> > intel_psr_entry_setup_frames is also of type int. so modified its type
> > to int.
> >
> > ./drivers/gpu/drm/i915/display/intel_psr.c:1336:5-23: WARNING: Unsigned expression compared with zero:
> entry_setup_frames >= 0.
> >
> > Reported-by: Abaci Robot <abaci@...ux.alibaba.com>
> > Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=7610
> > Signed-off-by: Jiapeng Chong <jiapeng.chong@...ux.alibaba.com>
> 
> There's already a patch. Mika, please follow up with it.
> 
> https://patchwork.freedesktop.org/patch/msgid/20231116090512.480373-1-mika.kahola@intel.com

The patch is now merged. Thanks for the review.

-Mika-
> 
> > ---
> >  drivers/gpu/drm/i915/display/intel_psr.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/gpu/drm/i915/display/intel_psr.c
> > b/drivers/gpu/drm/i915/display/intel_psr.c
> > index 8d180132a74b..204da50e3f28 100644
> > --- a/drivers/gpu/drm/i915/display/intel_psr.c
> > +++ b/drivers/gpu/drm/i915/display/intel_psr.c
> > @@ -1319,7 +1319,7 @@ static bool _psr_compute_config(struct intel_dp
> > *intel_dp,  {
> >  	struct drm_i915_private *dev_priv = dp_to_i915(intel_dp);
> >  	const struct drm_display_mode *adjusted_mode = &crtc_state->hw.adjusted_mode;
> > -	u8 entry_setup_frames;
> > +	int entry_setup_frames;
> >
> >  	/*
> >  	 * Current PSR panels don't work reliably with VRR enabled
> 
> --
> Jani Nikula, Intel