linux-kernel - Re: [PATCH v2 0/4] Extend time to wait for UIP for some callers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20231123083140e5e75ba2@mail.local>
Date:   Thu, 23 Nov 2023 09:31:40 +0100
From:   Alexandre Belloni <alexandre.belloni@...tlin.com>
To:     Mario Limonciello <mario.limonciello@....com>
Cc:     Mateusz Jończyk <mat.jonczyk@...pl>,
        Alessandro Zummo <a.zummo@...ertech.it>,
        "open list:REAL TIME CLOCK (RTC) SUBSYSTEM" 
        <linux-rtc@...r.kernel.org>,
        open list <linux-kernel@...r.kernel.org>,
        linux-pm@...r.kernel.org, tobrohl@...il.com, aalsing@...il.com,
        Dhaval.Giani@....com, xmb8dsv4@...il.com, x86@...nel.org,
        dhaval.giani@...il.com
Subject: Re: [PATCH v2 0/4] Extend time to wait for UIP for some callers

On 20/11/2023 08:15:51-0600, Mario Limonciello wrote:
> A number of users have reported their system will have a failure reading
> the RTC around s2idle entry or exit.
> 
> This failure manifests as UIP clear taking longer than 10ms.
> 
> By a debugging patch provided by Mateusz Jończyk it is shown that this
> has taken upwards of 300ms in some cases.
> 
> This series adjusts the UIP timeout to be configurable by the caller and
> changes some callers which aren't called in an interrupt context to allow
> longer timeouts.
> 
> Mario Limonciello (4):
>   rtc: mc146818-lib: Adjust failure return code for mc146818_get_time()
>   rtc: Adjust failure return code for cmos_set_alarm()
>   rtc: Add support for configuring the UIP timeout for RTC reads
>   rtc: Extend timeout for waiting for UIP to clear to 1s
> 
>  arch/alpha/kernel/rtc.c        |  2 +-
>  arch/x86/kernel/hpet.c         |  2 +-
>  arch/x86/kernel/rtc.c          |  2 +-


Please also copy the x86 maintainers so they know I'm going to carry
patches that may affect them (which I doubt will cause any issues)

>  drivers/base/power/trace.c     |  2 +-
>  drivers/rtc/rtc-cmos.c         | 10 ++++-----
>  drivers/rtc/rtc-mc146818-lib.c | 37 +++++++++++++++++++++++++---------
>  include/linux/mc146818rtc.h    |  3 ++-
>  7 files changed, 39 insertions(+), 19 deletions(-)
> 
> 
> base-commit: 98b1cc82c4affc16f5598d4fa14b1858671b2263
> -- 
> 2.34.1
> 

-- 
Alexandre Belloni, co-owner and COO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com