linux-kernel - Re: [PATCH] dt-bindings: dma: Drop undocumented examples

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZV8S0WAz+NbYUc84@matsya>
Date:   Thu, 23 Nov 2023 14:22:33 +0530
From:   Vinod Koul <vkoul@...nel.org>
To:     Rob Herring <robh@...nel.org>,
        Peter Ujfalusi <peter.ujfalusi@...il.com>,
        Jai Luthra <j-luthra@...com>
Cc:     Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Conor Dooley <conor+dt@...nel.org>, dmaengine@...r.kernel.org,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] dt-bindings: dma: Drop undocumented examples

On 22-11-23, 16:50, Rob Herring wrote:
> The compatibles "ti,omap-sdma" and "ti,dra7-dma-crossbar" aren't documented
> by a schema which causes warnings:
> 
> Documentation/devicetree/bindings/dma/dma-controller.example.dtb: /example-0/dma-controller@...00000: failed to match any schema with compatible: ['ti,omap-sdma']
> Documentation/devicetree/bindings/dma/dma-router.example.dtb: /example-0/dma-router@...02b78: failed to match any schema with compatible: ['ti,dra7-dma-crossbar']

So instead now we will have undocumented ti-omap-sdma?

Adding Peter and TI folks as well

> As no one has cared to fix them, just drop them.
> 
> Signed-off-by: Rob Herring <robh@...nel.org>
> ---
>  .../devicetree/bindings/dma/dma-controller.yaml   | 15 ---------------
>  .../devicetree/bindings/dma/dma-router.yaml       | 11 -----------
>  2 files changed, 26 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/dma/dma-controller.yaml b/Documentation/devicetree/bindings/dma/dma-controller.yaml
> index 04d150d4d15d..e6afca558c2d 100644
> --- a/Documentation/devicetree/bindings/dma/dma-controller.yaml
> +++ b/Documentation/devicetree/bindings/dma/dma-controller.yaml
> @@ -19,19 +19,4 @@ properties:
>  
>  additionalProperties: true
>  
> -examples:
> -  - |
> -    dma: dma-controller@...00000 {
> -        compatible = "ti,omap-sdma";
> -        reg = <0x48000000 0x1000>;
> -        interrupts = <0 12 0x4>,
> -                     <0 13 0x4>,
> -                     <0 14 0x4>,
> -                     <0 15 0x4>;
> -        #dma-cells = <1>;
> -        dma-channels = <32>;
> -        dma-requests = <127>;
> -        dma-channel-mask = <0xfffe>;
> -    };
> -
>  ...
> diff --git a/Documentation/devicetree/bindings/dma/dma-router.yaml b/Documentation/devicetree/bindings/dma/dma-router.yaml
> index 346fe0fa4460..5ad2febc581e 100644
> --- a/Documentation/devicetree/bindings/dma/dma-router.yaml
> +++ b/Documentation/devicetree/bindings/dma/dma-router.yaml
> @@ -40,15 +40,4 @@ required:
>  
>  additionalProperties: true
>  
> -examples:
> -  - |
> -    sdma_xbar: dma-router@...02b78 {
> -        compatible = "ti,dra7-dma-crossbar";
> -        reg = <0x4a002b78 0xfc>;
> -        #dma-cells = <1>;
> -        dma-requests = <205>;
> -        ti,dma-safe-map = <0>;
> -        dma-masters = <&sdma>;
> -    };
> -
>  ...
> -- 
> 2.42.0

-- 
~Vinod