[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <20231123101534.GC46439@kernel.org>
Date: Thu, 23 Nov 2023 10:15:34 +0000
From: Simon Horman <horms@...nel.org>
To: Rob Herring <robh@...nel.org>
Cc: Wolfgang Grandegger <wg@...ndegger.com>,
Marc Kleine-Budde <mkl@...gutronix.de>,
"David S. Miller" <davem@...emloft.net>,
Eric Dumazet <edumazet@...gle.com>,
Jakub Kicinski <kuba@...nel.org>,
Paolo Abeni <pabeni@...hat.com>,
Appana Durga Kedareswara rao <appana.durga.rao@...inx.com>,
Naga Sureshkumar Relli <naga.sureshkumar.relli@...inx.com>,
Michal Simek <michal.simek@....com>, linux-can@...r.kernel.org,
netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH v2] net: can: Use device_get_match_data()
On Wed, Nov 22, 2023 at 11:01:39AM -0700, Rob Herring wrote:
> Use preferred device_get_match_data() instead of of_match_device() to
> get the driver match data. With this, adjust the includes to explicitly
> include the correct headers.
>
> Error checking for matching and match data was not necessary as matching
> is always successful if we're already in probe and the match tables always
> have data pointers.
>
> Signed-off-by: Rob Herring <robh@...nel.org>
> ---
> v2:
> - Drop calling "platform_get_device_id(pdev)->driver_data" in c_can
> and flexcan as device_get_match_data() already did that. The logic
> was also wrong and would have resulted in returning -ENODEV.
> - Drop initializing devtype in xilinx_can
Thanks for the updates.
Reviewed-by: Simon Horman <horms@...nel.org>
Powered by blists - more mailing lists