linux-kernel - Re: [RFC PATCH 2/2] soundwire: fix initializing sysfs for same devices on different buses

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <479c16ce-da90-4571-bd08-b592d63f06cf@linaro.org>
Date:   Thu, 23 Nov 2023 11:58:19 +0100
From:   Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To:     Pierre-Louis Bossart <pierre-louis.bossart@...ux.intel.com>,
        alsa-devel@...a-project.org, srinivas.kandagatla@...aro.org
Cc:     tiwai@...e.de, broonie@...nel.org, vkoul@...nel.org,
        gregkh@...uxfoundation.org,
        Bard liao <yung-chuan.liao@...ux.intel.com>,
        Jaroslav Kysela <perex@...ex.cz>,
        Philippe Ombredanne <pombredanne@...b.com>,
        linux-kernel@...r.kernel.org, stable@...r.kernel.org,
        Vijendar Mukunda <Vijendar.Mukunda@....com>
Subject: Re: [RFC PATCH 2/2] soundwire: fix initializing sysfs for same
 devices on different buses

On 17/10/2023 18:09, Pierre-Louis Bossart wrote:
> From: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
> 
> If same devices with same device IDs are present on different soundwire
> buses, the probe fails due to conflicting device names and sysfs
> entries:
> 
>   sysfs: cannot create duplicate filename '/bus/soundwire/devices/sdw:0:0217:0204:00:0'
> 
> The link ID is 0 for both devices, so they should be differentiated by
> the controller ID. Add the controller ID so, the device names and sysfs entries look
> like:
> 
>   sdw:1:0:0217:0204:00:0 -> ../../../devices/platform/soc@...ab0000.soundwire-controller/sdw-master-1-0/sdw:1:0:0217:0204:00:0
>   sdw:3:0:0217:0204:00:0 -> ../../../devices/platform/soc@...b10000.soundwire-controller/sdw-master-3-0/sdw:3:0:0217:0204:00:0
> 
> [PLB changes: use bus->controller_id instead of bus->id]
> 
> Fixes: 7c3cd189b86d ("soundwire: Add Master registration")
> Cc: <stable@...r.kernel.org>
> Reviewed-by: Bard Liao <yung-chuan.liao@...ux.intel.com>
> Reviewed-by: Vijendar Mukunda <Vijendar.Mukunda@....com>
> Co-developed-by: Pierre-Louis Bossart <pierre-louis.bossart@...ux.intel.com>
> Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@...ux.intel.com>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>

The order of SoB is not correct. Author's goes before co-developed.


Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>

Tested-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>

Best regards,
Krzysztof