linux-kernel - Re: [PATCH 0/2] bootconfig: Support early options in embedded config

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20231123105833.419a9cda0fc25f45a877b436@kernel.org>
Date:   Thu, 23 Nov 2023 10:58:33 +0900
From:   Masami Hiramatsu (Google) <mhiramat@...nel.org>
To:     Petr Malat <oss@...at.biz>
Cc:     linux-kernel@...r.kernel.org, mhiramat@...nel.org,
        paulmck@...nel.org, rostedt@...dmis.org
Subject: Re: [PATCH 0/2] bootconfig: Support early options in embedded
 config

Hi Petr,

Thanks for the patch.

On Wed, 22 Nov 2023 00:13:40 +0100
Petr Malat <oss@...at.biz> wrote:

> These 2 patches add a support for specifying early options in embedded
> bootconfig and merging embedded and initrd bootconfig into one.
> 
> To allow handling of early options, it's necessary to eliminate allocations
> from embedded bootconfig handling, which can be done by parsing the config
> data in place and allocating xbc_nodes array statically.

Hm, my concern is that this can introduce some sort of overhead to parse
the bootconfig.

> 
> Later, when initrd is available, it either replaces embedded data or is
> appended to them. To append initrd data, it's necessary to relocate already
> parsed data to a bigger memory chunk, but that's not a problem, because
> xbc_node structure uses offsets and not absolute pointers.

However, as you did on this series, it is OK that it does an additional parse
for the initrd bootconfig (do not parse twice)

Let me comment your patch.

Thanks!

> 
> Also, update the documentation to make users aware early options can't be
> configured in the initrd.
> 
> 


-- 
Masami Hiramatsu (Google) <mhiramat@...nel.org>