linux-kernel - Re: [PATCH net-next v3 3/3] net: stmmac: Add driver support for DWMAC5 fault IRQ Support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1e02f4f8-ebd3-4f57-98a9-48d7e08c0ad4@linaro.org>
Date:   Thu, 23 Nov 2023 12:55:38 +0100
From:   Konrad Dybcio <konrad.dybcio@...aro.org>
To:     Suraj Jaiswal <quic_jsuraj@...cinc.com>,
        Vinod Koul <vkoul@...nel.org>,
        Bhupesh Sharma <bhupesh.sharma@...aro.org>,
        Andy Gross <agross@...nel.org>,
        Bjorn Andersson <andersson@...nel.org>,
        "David S. Miller" <davem@...emloft.net>,
        Eric Dumazet <edumazet@...gle.com>,
        Jakub Kicinski <kuba@...nel.org>,
        Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Conor Dooley <conor+dt@...nel.org>,
        Alexandre Torgue <alexandre.torgue@...s.st.com>,
        Jose Abreu <joabreu@...opsys.com>,
        Maxime Coquelin <mcoquelin.stm32@...il.com>,
        netdev@...r.kernel.org, linux-arm-msm@...r.kernel.org,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux-stm32@...md-mailman.stormreply.com,
        Prasad Sodagudi <psodagud@...cinc.com>,
        Andrew Halaney <ahalaney@...hat.com>
Cc:     kernel@...cinc.com
Subject: Re: [PATCH net-next v3 3/3] net: stmmac: Add driver support for
 DWMAC5 fault IRQ Support



On 11/23/23 12:38, Suraj Jaiswal wrote:
> Add IRQ support to listen HW fault like ECC,DPP,FSM
> fault and print the fault information in the kernel
> log.
> 
> Signed-off-by: Suraj Jaiswal <quic_jsuraj@...cinc.com>
> ---
>   drivers/net/ethernet/stmicro/stmmac/common.h  |  1 +
>   drivers/net/ethernet/stmicro/stmmac/stmmac.h  |  2 ++
>   .../net/ethernet/stmicro/stmmac/stmmac_main.c | 18 +++++++++++++++++
>   .../ethernet/stmicro/stmmac/stmmac_platform.c | 20 +++++++++++++++++++
>   4 files changed, 41 insertions(+)
> 
> diff --git a/drivers/net/ethernet/stmicro/stmmac/common.h b/drivers/net/ethernet/stmicro/stmmac/common.h
> index 6b935922054d..c4821c7ab674 100644
> --- a/drivers/net/ethernet/stmicro/stmmac/common.h
> +++ b/drivers/net/ethernet/stmicro/stmmac/common.h
> @@ -347,6 +347,7 @@ enum request_irq_err {
>   	REQ_IRQ_ERR_SFTY_UE,
>   	REQ_IRQ_ERR_SFTY_CE,
>   	REQ_IRQ_ERR_LPI,
> +	REQ_IRQ_ERR_SAFETY,
>   	REQ_IRQ_ERR_WOL,
>   	REQ_IRQ_ERR_MAC,
>   	REQ_IRQ_ERR_NO,
> diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac.h b/drivers/net/ethernet/stmicro/stmmac/stmmac.h
> index cd7a9768de5f..8893d4b7fa38 100644
> --- a/drivers/net/ethernet/stmicro/stmmac/stmmac.h
> +++ b/drivers/net/ethernet/stmicro/stmmac/stmmac.h
> @@ -33,6 +33,7 @@ struct stmmac_resources {
>   	int irq;
>   	int sfty_ce_irq;
>   	int sfty_ue_irq;
> +	int safety_common_intr;
>   	int rx_irq[MTL_MAX_RX_QUEUES];
>   	int tx_irq[MTL_MAX_TX_QUEUES];
>   };
> @@ -331,6 +332,7 @@ struct stmmac_priv {
>   	/* XDP BPF Program */
>   	unsigned long *af_xdp_zc_qps;
>   	struct bpf_prog *xdp_prog;
> +	int safety_common_intr;
other interrupts use _irq yet you seem to use _intr, plus the
aforementioned "safety" vs "fault" naming

[...]

>   
> +int stmmac_get_fault_intr_config(struct platform_device *pdev, struct stmmac_resources *res)
> +{
> +	int ret = 0;
get rid of ret and return directly

> +
> +	res->safety_common_intr = platform_get_irq_byname(pdev, "safety");
> +
stray newline?

> +	if (res->safety_common_intr < 0) {
> +		if (res->safety_common_intr != -EPROBE_DEFER)
> +			dev_err(&pdev->dev, "safety IRQ configuration information not found\n");
> +		ret = 1;
> +	}
> +
> +	return ret;
> +}
> +
>   int stmmac_get_platform_resources(struct platform_device *pdev,
>   				  struct stmmac_resources *stmmac_res)
>   {
> +	int ret = 0;
Missing newline between declarations and code
Unnecessary initialization

>   	memset(stmmac_res, 0, sizeof(*stmmac_res));
>   
>   	/* Get IRQ information early to have an ability to ask for deferred
> @@ -702,6 +718,10 @@ int stmmac_get_platform_resources(struct platform_device *pdev,
>   	if (stmmac_res->irq < 0)
>   		return stmmac_res->irq;
>   
> +	ret = stmmac_get_fault_intr_config(pdev, stmmac_res);
> +	if (ret)
> +		dev_err(&pdev->dev, "Fault interrupt not present\n");
Since you're getting the return value, perhaps the errno should
be propagated

Konrad