linux-kernel - Re: [PATCH] hwmon: sht3x: read out sensor serial number

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <52909c46-4699-442b-9303-ec914fba093b@roeck-us.net>
Date:   Fri, 24 Nov 2023 09:34:48 -0800
From:   Guenter Roeck <linux@...ck-us.net>
To:     Stefan Gloor <code@...fan-gloor.ch>, jdelvare@...e.com,
        corbet@....net, linux-hwmon@...r.kernel.org,
        linux-doc@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] hwmon: sht3x: read out sensor serial number

On 11/24/23 06:55, Stefan Gloor wrote:
> Some of the temperature/humidity sensors of the STS3x/SHT3x family are
> calibrated and factory-programmed with a unique serial number. This serial
> number can be used to obtain a calibration certificate via an API provided
> by the manufacturer (Sensirion). The serial number is exposed as a
> non-standard sysfs attribute.
> 
> This feature is only available for STS32, STS33 and SHT33. The capability
> to read out the serial number is not documented for other sensors such as
> the STS31, but it is implemented in the ones I tested. To be safe, the
> driver will silently set the serial number to zero if it can not be read.
> 
> Tested with:
> 1x STS32: serial number present
> 2x STS31: serial number present (feature not documented)
> 1x SHT31: serial number present (feature not documented)
> 
> Signed-off-by: Stefan Gloor <code@...fan-gloor.ch>

I am not going to accept this as sysfs attribute. Please implement
using debugfs.


Also, the attribute (sysfs or debugfs) should not exist if not supported.
Please only provide if supported.

Thanks,
Guenter