linux-kernel - Re: [PATCH V3 2/2] mm: page_alloc: enforce minimum zone size to do high atomic reserves

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <01c81f6a-f090-a544-49db-ed9cd97ab8ee@google.com>
Date:   Fri, 24 Nov 2023 11:24:28 -0800 (PST)
From:   David Rientjes <rientjes@...gle.com>
To:     Charan Teja Kalla <quic_charante@...cinc.com>
cc:     akpm@...ux-foundation.org, mgorman@...hsingularity.net,
        mhocko@...e.com, david@...hat.com, vbabka@...e.cz,
        hannes@...xchg.org, quic_pkondeti@...cinc.com, linux-mm@...ck.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH V3 2/2] mm: page_alloc: enforce minimum zone size to do
 high atomic reserves

On Fri, 24 Nov 2023, Charan Teja Kalla wrote:

> Highatomic reserves are set to roughly 1% of zone for maximum and a
> pageblock size for minimum.  Encountered a system with the below
> configuration:
> Normal free:7728kB boost:0kB min:804kB low:1004kB high:1204kB
> reserved_highatomic:8192KB managed:49224kB
> 
> On such systems, even a single pageblock makes highatomic reserves are
> set to ~8% of the zone memory. This high value can easily exert pressure
> on the zone.
> 
> Per discussion with Michal and Mel, it is not much useful to reserve
> the memory for highatomic allocations on such small systems[1]. Since
> the minimum size for high atomic reserves is always going to be a
> pageblock size and if 1% of zone managed pages is going to be below
> pageblock size, don't reserve memory for high atomic allocations. Thanks
> Michal for this suggestion[2].
> 
> Since no memory is being reserved for high atomic allocations and if
> respective allocation failures are seen, this patch can be reverted.
> 
> [1] https://lore.kernel.org/linux-mm/20231117161956.d3yjdxhhm4rhl7h2@techsingularity.net/
> [2] https://lore.kernel.org/linux-mm/ZVYRJMUitykepLRy@tiehlicka/
> 
> Signed-off-by: Charan Teja Kalla <quic_charante@...cinc.com>

Acked-by: David Rientjes <rientjes@...gle.com>